Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<abbr> dotted underling now supported by Chrome (et al.) #340

Closed
jonnystening opened this issue Jul 3, 2017 · 2 comments
Closed

<abbr> dotted underling now supported by Chrome (et al.) #340

jonnystening opened this issue Jul 3, 2017 · 2 comments

Comments

@jonnystening
Copy link
Contributor

jonnystening commented Jul 3, 2017

Chrome has recently turned on dotted underlining of <abbr> elements by default (as per Opera and Firefox' implementation) https://www.chromestatus.com/feature/4774625963671552

screen shot 2017-07-03 at 10 20 08 am
https://developer.mozilla.org/en/docs/Web/HTML/Element/abbr

We are currently forcing a 1px dotted bottom border under <abbr> elements, but with the recent changes users will see a double underline.

screen shot 2017-07-03 at 10 17 09 am

Firefox also forces this underline (Safari does not at this stage). Not sure about IE, but it's likely we're going to have to remove that 1px dotted bottom border styling (or remove the browser implementation with text-decoration: none; and force our own styling).

@justinspencer @mpcat

@jonnystening
Copy link
Contributor Author

jonnystening commented Jul 11, 2017

Just looking into this a little further... we are actually overriding the consistent underlining solution provided by Normalize.css.

nb. Normalize could do with a version bump. We're using v4.2.0 (currently v7.0.0) #348

@jonnystening
Copy link
Contributor Author

This double underlining issue was fixed in Text Styling v2.0.1. We will keep the dotted bottom border styling as it's clearer than the dotted underline provided by browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants