-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about MAE #10
Comments
Hi there, |
Hi William, thank you for raising this issue. For your 1st question about the error metric calculation, sure, you can invert the transformation before calculating, but this asks for one more unnecessary inverse step. Please remember that the purpose of error metrics is to make fair comparisons between all methods. No matter we make the inverse or not, the comparisons in our experiments are impartial. For the 2nd question about your imputation results, I personally think this is normal because there're fluctuations in your original data, e.g. data from 2013/6/4 to 2013/7/24 in the bottom fig in your screenshot. I know you may want to make the imputation look more smooth, namely, not so many flips. I'd suggest you try to 1). tune the hyperparameters of SAITS to make the model not overfit the original data; 2). try to add additional methods to smooth the imputation, e.g. add additional loss constraints, or add post-processing steps to manually eliminate these too many flips. |
Thanks very much, your reply help me a lot. |
My pleasure. |
Hi, Wenjie
I have a little doubt about the calculation of MAE.
I found you normalizes the dataset with standard scaling, it means the
target
andinput
are standard normalized. So why not calculate MAE after inverse the scaling to them?The text was updated successfully, but these errors were encountered: