-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to deal with colons, hyphens in full BTCR DID strings? #16
Comments
Are these questions about characters that might exist in the 'did-url' parts described in https://w3c-ccg.github.io/did-spec/#generic-did-syntax? As far as the 'method-specific-id' part of our 'did', according to BIP-0136, any non-valid characters are to be ignored before decoding. For example, "y#$%jk0$%^-u$%^&qa^&(y-#$%z^&u4x^&-nk%^&(6u-^&*(pc" and "yjk0-uqay-zu4x-nk6u-pc" should decode to the same transaction parameters. So at least there, it doesn't matter what separators we define, but as you mention, for canonicalization (and signing) purposes, we should define what our separators MUST be. Our C++ code simply adds hyphens every 4 characters, so: "xjk0-uqay-zat0-dz8" or "8jk0-uqay-zu4x-aw4h-zl". However, if you are all asking about 'did-url' stuff, like 'param', 'path', 'query' or 'fragment', I think I'll wait until I get caught up with the rest of the discussion. |
I'd suggest that for the same reasons as @kimdhamilton mentioned in #5, there should only be one valid form of BTCR DID, e.g. the method spec should REQUIRE the 4-4-4-3 and 4-4-4-4-2 forms that various libraries use, even though (as @danpape explains) on the BIP-0136 level multiple equivalent forms are allowed. |
I agree with @peacekeeper; this treatment should be consistent. |
I think we need to revisit this |
Revisit as in make a final decision, or do you have new questions? |
Discussion
Decisions? (Note that some of this seems inconsistent with tx output 0 handling, where we treat as error)
The text was updated successfully, but these errors were encountered: