Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The obligatory naming discussion #10

Open
kimdhamilton opened this issue Aug 7, 2019 · 4 comments
Open

The obligatory naming discussion #10

kimdhamilton opened this issue Aug 7, 2019 · 4 comments

Comments

@kimdhamilton
Copy link
Collaborator

Let's kick it off here. Many of our names are outdated. What should they be now?

Naming discussion

  • continuation/final/constructed DID Document
  • implicit DID Document
  • service/proof purpose
  • audit trail generic vs specific (aka satoshi)
@ChristopherA
Copy link
Member

We also need to discuss naming conventions for standard keys for BTCR-based DID Documents:

  • #satoshi-transaction-key vs #satoshi
  • #verifiable-credential-issuance-key #vckey-0

see example of usage in: #4 (comment)

-- Christopher Allen

@danpape
Copy link
Collaborator

danpape commented Aug 7, 2019

Can I add something about txrefs here? We used to have "txref", then we talked about "txref-ext" or "txref-extended", which included our changes for adding the utxo index. Recently I have noticed people (including myself) say "short" and "long" txref.

I suppose since now that we have had BIP-0136 accepted, there is no longer any need for "extended", so maybe "short txref" and "long txref" are OK? Or even, if we can help ourselves, just say "txref" all the time?

@peacekeeper
Copy link
Member

@danpape :

maybe "short txref" and "long txref" are OK?

Sounds good to me, just wanted to mention the libtxref-java library calls it "extended", that should be made consistent then. BIP-0136 seems to call it "with outpoints".

@danpape
Copy link
Collaborator

danpape commented Aug 8, 2019

Yes, I'll clean everything up in all the code once we settle on something.

As for "with outpoints" -- that is what the original BIP-0136 authors liked to use. Ryan and I looked into this and found that is how utxos and txos are referred to in the bitcoin code.

I'm hoping to issue a new PR to update BIP-0136 soon, once all of the implementations settle down as there are missing ones in the BIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants