New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider syncing capability checks #7

Open

tw2113 opened this issue Apr 29, 2020 · 1 comment

Milestone

Member

tw2113 commented Apr 29, 2020

We check for manage_options for the admin screen, but install_plugins for the actual action of running the switching.

Perhaps make install_plugins the requirement to even see the admin screen?

Original issue:
https://wordpress.org/support/topic/does-not-respect-capabilities-canyou-please-fix-asap/#post-12748575

Contributor

sc0ttkclark commented Apr 30, 2020

manage_options is used for the management menu page:

taxonomy-switcher/Taxonomy_Switcher_UI.php

Line 87 in 52b0fea

$this->options_page = add_management_page( $this->admin_title, $this->admin_title, 'manage_options', $this->admin_slug, array(
install_plugins is used for running the conversion:

taxonomy-switcher/taxonomy-switcher.php

Line 51 in 52b0fea

|| ! current_user_can( 'install_plugins' )

I suggest manage_options should be the capability used for both.

tw2113 added this to the 1.1.0 milestone

alokstha1 mentioned this issue

Replaced all capabilities to manage_options #10

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment