Handle Vimeo serving WebP images #69
Comments
|
Personally I don't like losing Vimeo support. It's currently "one of the big 2" and many businesses use them. In my current application of this plugin, I actually use a custom Vimeo get to authenticate so I can pull thumbnails of protected content. Have you thought about a premium version of the plugin to provide addition support for protected content? Revenue could help offset the development costs for this. I'd be willing to help contribute/partner on this. Also, what's the harm in simply changing the image to the one with a play button on it (at least temporarily)--to continue Vimeo support. To me this doesn't seem like it should be a deal killer. Another thought is to look for a 3rd party cloud service or library that we could use to get the webp from Vimeo and then convert to a PNG or JPG for upload to WP. Not the most elegant, but yea it could work. |
|
If there's somewhere within Vimeo's public API endpoints and everything, that isn't WebP, then we can definitely re-point things to that for the pre-5.8 users and generally recover earlier users until they're on a version of WP that does support WebP. Just a matter of identifying one. I'd prefer not seeking out and relying on a 3rd party image converting service. |
|
So there is. I had posted this on the WP support forum a few days ago. Here's the sample response from the API and you can see that there's a "link_with_play_button" parameter that's a PNG. |
|
Not sure what endpoint that is from, but I'm all ears. That said, I just tested some things with our current implementation, so good timing on your comment. Say we're trying to embed https://vimeo.com/552398689 We get a response of https://i.vimeocdn.com/video/1141331067_640.jpg So we could probably just force one, instead of rely on letting it choose itself, until perhaps WP has webp support later this summer, or just permanently. |
|
Looks like that works. I was using this endpoint: /videos/{video_id}/pictures to get the private video images. |
|
@Nicscott01 i feel like maybe a filter override for API endpoint may be beneficial for you. Where someone could do their own endpoint fetches and return the appropriate detail, like the image URL or similar. Would you agree? |
|
Yes, a filter for custom API endpoint would be very helpful. Thank you! |
|
Still wanting to leave things open here for the custom endpoint, but even with WP 5.8 beta 3, it didn't seem to be recognizing the webp endpoint, even when i explicitly appended |
|
First part handled in 54bfb10 |
|
@Nicscott01 Can you point out and remind me where you're doing custom endpoints at? For example, are you in the |
|
I’m doing it in wds_get_vimeo_details().
My workaround for now was to:
remove_action( 'save_post', 'wds_check_if_content_contains_video', 10, 2 );
add_action( 'save_post', 'lsta_check_if_content_contains_video', 10, 2 );
And then write my own function lsta_get_vimeo_details().
LMK if that makes sense.
… On Jun 25, 2021, at 2:18 PM, Michael Beckwith ***@***.***> wrote:
@Nicscott01 <https://github.com/Nicscott01> Can you point out and remind me where you're doing custom endpoints at? For example, are you in the wds_check_for_vimeo() function or wds_get_vimeo_details() ? Trying to determine the best place to provide an override.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#69 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABUCZCJDGHOZ4YELOEBC55DTUTB6RANCNFSM45W7GNWQ>.
|
|
It does, but at the same time it's taking over everything really early in the process and basically overriding EVERYTHING. Would you be willing to zip up your copy and share it with me? I'd like to do a diff comparison to see all the changes done. Even just gist pastes of the main file, and whatever you've set up for your |
|
I'm going to punt the override details to a later release as I don't want to hold up on a 1.2.0 which has some good fixes in it. |
Vimeo has switched to WebP. It's also switched to image URLs that have no file type suffix.
Example:
https://i.vimeocdn.com/video/1141331067_640
WordPress does not yet support WebP in the media library at the time of this post. However it should in WP 5.8 as per https://core.trac.wordpress.org/ticket/35725
I think we need to do a couple things.
Only downside to item 2 is that it leaves previous users in the dark for Vimeo support, as we can't control what they serve.
The text was updated successfully, but these errors were encountered: