Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release request #348

Closed
yamt opened this issue Sep 7, 2023 · 23 comments
Closed

release request #348

yamt opened this issue Sep 7, 2023 · 23 comments

Comments

@yamt
Copy link
Contributor

yamt commented Sep 7, 2023

can you consider to make a release which includes the following libc bumps?
thank you.

#340
#344

@abrown
Copy link
Collaborator

abrown commented Sep 16, 2023

Sure, I can start looking into making a new release. Some things to think about:

@yamt
Copy link
Contributor Author

yamt commented Sep 17, 2023

Sure, I can start looking into making a new release. Some things to think about:

* should we wait for LLVM 17 to be [released ](https://github.com/llvm/llvm-project/releases/) in case anyone wants something from that?

* should we wait for [Rename wasm32-wasi-threads target to wasm32-wasi-preview1-threads wasi-libc#434](https://github.com/WebAssembly/wasi-libc/pull/434) and [Update thread id validation returned by `__wasi_thread_spawn` wasi-libc#435](https://github.com/WebAssembly/wasi-libc/pull/435)?

i don't think we should wait for any of the above.
i guess it's a bit more user-friendly to avoid tying bug fixes and major changes like llvm bump together.

@glebpom
Copy link

glebpom commented Sep 20, 2023

LLVM 17 is released now

@abrown
Copy link
Collaborator

abrown commented Sep 26, 2023

i guess it's a bit more user-friendly to avoid tying bug fixes and major changes like llvm bump together.

I agree with that in general, but in this case I am just trying to reduce work: two birds, one stone. It seems like there's always some kind of change that someone wants that makes it in to the next release (e.g., annotations). @yamt, are you interested in trying the LLVM version bump and then I'll work on the release?

@yamt
Copy link
Contributor Author

yamt commented Sep 27, 2023

sorry, is making a release that much work?

@abrown
Copy link
Collaborator

abrown commented Sep 28, 2023

More than I would like it to! The CI scripts help but it's still a bit manual... and things can go wrong. That's why I haven't set up a "one click to release" CI job.

@abrown
Copy link
Collaborator

abrown commented Sep 28, 2023

Also, I'm hearing that @dicej might want to get WebAssembly/wasi-libc#429 in to this release?

@dicej
Copy link
Contributor

dicej commented Sep 28, 2023

Indeed I do. Just need someone with authority to approve and merge it. Happy to help with the release process, too.

@yamt
Copy link
Contributor Author

yamt commented Sep 28, 2023

just WebAssembly/wasi-libc#429?
or do you mean to finish #338 as well?

@dicej
Copy link
Contributor

dicej commented Sep 28, 2023

just WebAssembly/wasi-libc#429? or do you mean to finish #338 as well?

Both. I've been waiting for the wasi-libc PR to be merged so I can update the submodule in wasi-sdk.

@dicej
Copy link
Contributor

dicej commented Sep 28, 2023

Looks like that's happened, so I'll update #338 today.

@dicej
Copy link
Contributor

dicej commented Sep 28, 2023

I've updated #338 and marked it "ready for review".

@rockwotj
Copy link

Personally, I'd love a release with clang 17, but not sure how much more #338 needs

@dicej
Copy link
Contributor

dicej commented Nov 26, 2023

I think #338 is ready to merge now. BTW, LLVM 17.0.6 is scheduled to be released two days from now, so we might consider waiting for that rather than the release/17.x snapshot I pointed to in #338.

@turbolent
Copy link

Would it be possible to release a bugfix release with the threading bugfixes in libc?

@yamt
Copy link
Contributor Author

yamt commented Nov 27, 2023

I think #338 is ready to merge now. BTW, LLVM 17.0.6 is scheduled to be released two days from now, so we might consider waiting for that rather than the release/17.x snapshot I pointed to in #338.

i think it makes sense to wait for the release.

@yamt
Copy link
Contributor Author

yamt commented Nov 27, 2023

Would it be possible to release a bugfix release with the threading bugfixes in libc?

those fixes which have already been merged in wasi-libc will be in the next release i guess.

or, do you mean to have a separate bugfix-only release?
@abrown prefers to have more things in a release to save releng efforts.

@loganek
Copy link

loganek commented Nov 28, 2023

Is there a plan to enable exceptions support in the upcoming release?

@dicej
Copy link
Contributor

dicej commented Nov 28, 2023

I think #338 is ready to merge now. BTW, LLVM 17.0.6 is scheduled to be released two days from now, so we might consider waiting for that rather than the release/17.x snapshot I pointed to in #338.

i think it makes sense to wait for the release.

I've updated #338 to use LLVM 17.0.6.

@abrown
Copy link
Collaborator

abrown commented Nov 29, 2023

Ok, as I understand it, once #338 gets merged then we can release v21? I.e., nothing else out there that anyone has been waiting on?

@yamt
Copy link
Contributor Author

yamt commented Nov 29, 2023

Is there a plan to enable exceptions support in the upcoming release?

i don't think so.

@yamt
Copy link
Contributor Author

yamt commented Nov 29, 2023

I think #338 is ready to merge now. BTW, LLVM 17.0.6 is scheduled to be released two days from now, so we might consider waiting for that rather than the release/17.x snapshot I pointed to in #338.

i think it makes sense to wait for the release.

I've updated #338 to use LLVM 17.0.6.

thank you.

@abrown
Copy link
Collaborator

abrown commented Dec 18, 2023

Ok, I'm closing this now that wasi-sdk-21 has been published as a pre-release. We can promote it to a full release whenever; I just wanted to give people a chance to test things out.

@abrown abrown closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants