You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Emscripten enables WASM_BIGINT by default now and the feature is very widely supported, so if there is a benefit to enabling it, then we should fix the Binaryen bindings.
The text was updated successfully, but these errors were encountered:
…ff (#7162)
This handles the case where WASM_BIGINT is enabled by default by emcc.
Binaryen's JS bindings do not currently work with bigint (see #7163)
We previously had a build option for enabling BigInt support when
compiling with Emscripten, but the test suite did not actually pass with
it enabled. The problem was that the binaryen.js glue code assumed that
C API functions that took i64 parameters would be transformed to take a
pair of i32 parameters instead, but this assumption was incorrect when
BigInt support was enabled.
Emscripten has now enabled BigInt by default, so update binaryen.js to
use BigInt as well. Fix the JS API glue code to pass i64s as BigInts
rather than pairs of numbers and fix the tests accordingly. Also fix
some other small problems with the tests that only show up in debug
builds.
Resolves#7163.
Currently the tests fail when BIGINT is enabled:
https://github.com/WebAssembly/binaryen/actions/runs/12406958589/job/34636211812?pr=7161
Emscripten enables WASM_BIGINT by default now and the feature is very widely supported, so if there is a benefit to enabling it, then we should fix the Binaryen bindings.
The text was updated successfully, but these errors were encountered: