Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header-subtitle-name does not make grammatical sense #1638

Open
knoll3 opened this issue Nov 18, 2023 · 1 comment
Open

header-subtitle-name does not make grammatical sense #1638

knoll3 opened this issue Nov 18, 2023 · 1 comment

Comments

@knoll3
Copy link

knoll3 commented Nov 18, 2023

Is your feature request related to a problem? Please describe.

The text from header-subtitle-name found in english.json doesn't seem to make grammatical sense within it's context. Text can be found here:

// english.json
"header-subtitle-name": "Your {{appName}} wallet with one click",

The result ends up looking like this in the Sign In modal when "FLock Client" is used as the appName
image

The sentence "Your FLock Client wallet with one click" doesn't really make sense.

Describe the solution you'd like

The header-subtitle-name should read like this:

// english.json
"header-subtitle-name": "Sign in to your {{appName}} wallet with one click",

This way it would read: "Sign in to your FLock Client wallet with one click".

Of course, every other language besides english would also have to be considered. But one step at a time.

Describe alternatives you've considered

An alternative would be to say "to your {{appname}} wallet with one click" since the text immediately above it is "Sign In". So it would be like saying "Sign in to your {{appname}} wallet with one click".

Additional context

N/A

@chaitanyapotti
Copy link
Member

Looking into this. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants