Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faraday 1.x can bypass Diplomat::QueryAlreadyExists #227

Open
tlbraams opened this issue Aug 19, 2022 · 1 comment · May be fixed by #228
Open

Faraday 1.x can bypass Diplomat::QueryAlreadyExists #227

tlbraams opened this issue Aug 19, 2022 · 1 comment · May be fixed by #228

Comments

@tlbraams
Copy link

Faraday 1 made changes to the Faraday::ClientError, introducing Faraday::ServerError (https://github.com/lostisland/faraday/blob/main/UPGRADING.md#errors)

This split the errors, with client errors now responsible for 4xx codes and server errors for 5xx codes.
The Diplomat::Query#create method only expects/handles client errors. As such, (some) errors that were previously caught and reported as Diplomat::QueryAlreadyExists, now raise Faraday::ServerError.
@pierresouchay
Copy link
Member

@tlbraams what would you suggest? Do you feel doing a PR?

Regards

@tlbraams tlbraams linked a pull request Aug 22, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle Faraday::ServerError in Diplomat::Query#create tlbraams/diplomat
2 participants
@pierresouchay @tlbraams