Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: accept ISO dates #7

Open
chrisjbillington opened this issue May 18, 2021 · 5 comments
Open

Feature request: accept ISO dates #7

chrisjbillington opened this issue May 18, 2021 · 5 comments

Comments

@chrisjbillington
Copy link

RemindMeBot doesn't seem to accept ISO dates, with requests like "RemindMe! 2022-01-01" getting the "defaulted to one day" response.

It would be good if RemindMe bot did accept ISO dates. I imagine these are simpler to parse than many of the date formats it does accept!

@Watchful1
Copy link
Owner

That seems to work fine for me. Where are you seeing it not work?

@chrisjbillington
Copy link
Author

@Watchful1
Copy link
Owner

Ah, that's a common bug I've never been able to completely get rid of. The bot requires the exclamation point to trigger, but then it uses the first instance of "remindme" in the comment to get the date. So it triggered based on the command in "RemindMe! 2022-01-01", but then it tried to find the date in "Extra prompt for remindme bot, which seemed to miss this comment:" since that also has "remindme" in it. And of course there's no date in that line, so it defaulted.

I really need to rework the whole regex system that extracts the date, but there's always some edge case I break and end up giving up.

@chrisjbillington
Copy link
Author

I see! Well, I'll keep using isodates then, and refrain from mentioning remindmebot's name in other parts of the comment to avoid triggering the existing bug.

Feel free to close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants