Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripten version 3.1.42 and up cause errors in the js output #111

Closed
NTM-Adam opened this issue Jul 26, 2023 · 4 comments
Closed

Emscripten version 3.1.42 and up cause errors in the js output #111

NTM-Adam opened this issue Jul 26, 2023 · 4 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@NTM-Adam
Copy link

When compiling patches with emscripten versions > 3.1.41, the outputted js wrapper throws errors such as the following:

Converting base64 string to bytes failed

Upon debugging, it appears there was a reference error around the atob() function, previous versions included a fallback for this function in the compiled output.

@dromer dromer added bug Something isn't working help wanted Extra attention is needed labels Jul 26, 2023
@dromer dromer assigned dromer and chrisuehlinger and unassigned dromer Jul 30, 2023
@dromer
Copy link
Collaborator

dromer commented Jul 30, 2023

Hmm, possibly we just need to add it to DEFAULT_LIBRARY_FUNCS_TO_INCLUDE section?

@dromer
Copy link
Collaborator

dromer commented Nov 4, 2023

This possibly got fixed here: emscripten-core/emscripten#20587

@dromer
Copy link
Collaborator

dromer commented Dec 12, 2023

@NTM-Adam did you get a chance to try latest emscripten yet?

@dromer
Copy link
Collaborator

dromer commented Dec 12, 2023

Hmm, I just tested with 3.1.50 and I still see ReferenceError: atob is not defined in the console.

[edit: ok I figured it out from some posts on the emsdk issue tracker: we need to add shell to the AudioLibWorklet emcc ENVIRONMENT and then it works!]

@dromer dromer closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Development

No branches or pull requests

3 participants