Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black Market crashes the game #3

Open
lutzee opened this issue Jun 20, 2018 · 4 comments
Open

Black Market crashes the game #3

lutzee opened this issue Jun 20, 2018 · 4 comments
Labels

Comments

@lutzee
Copy link

lutzee commented Jun 20, 2018

Describe the bug
On some servers, trying to use the black market will crash the game.

To Reproduce
Steps to reproduce the behavior:

  1. Open black market
  2. Game Crashes

Expected behavior
Game does not crash and shows the black market

Server or Client?

  • Client
@lutzee lutzee added the client label Jun 20, 2018
@kbasten
Copy link

kbasten commented Jun 21, 2018

Fixed, issue caused by mysql settings

@lutzee
Copy link
Author

lutzee commented Jun 21, 2018

Can you explain what was wrong so others can fix it if they have the same problem?

@kbasten
Copy link

kbasten commented Jun 22, 2018

Yes, this is due to the setting ONLY_FULL_GROUP_BY active by default in mysql 5.7+. You can turn this setting off by running the following query:
SET GLOBAL sql_mode=(SELECT REPLACE(@@sql_mode,'ONLY_FULL_GROUP_BY',''));
This does however have the effect of the black market prices not being deterministic in the overview. This is why prices might differ in the black market list and the actual buy panel. There is no fix for that at the moment.

@LordRalex LordRalex added server and removed client labels Jun 25, 2018
@AndrewSav
Copy link

Note that SET GLOBAL sql_mode=(SELECT REPLACE(@@sql_mode,'ONLY_FULL_GROUP_BY','')); does not survive reboot. I ended up specifying sql-mode on the command line when starting mysql to solve it completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants