From 5db06b28e869ce8e2713a3772ff21e7d1959015f Mon Sep 17 00:00:00 2001 From: Maks Orlovich Date: Mon, 24 Jul 2023 14:29:04 -0400 Subject: [PATCH] Fix buglet in setPrioritySignals. (#712) The second argument can be omitted/set to null/undefined to erase mapping for a key. The actual handling logic was already handling that, but we were not accepting this in the signature, or permitting in the infra rep. Co-authored-by: Maks Orlovich --- spec.bs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec.bs b/spec.bs index 70de7bcde..eb8620ba7 100644 --- a/spec.bs +++ b/spec.bs @@ -2299,7 +2299,7 @@ interface InterestGroupBiddingScriptRunnerGlobalScope : InterestGroupScriptRunnerGlobalScope { boolean setBid(optional GenerateBidOutput generateBidOutput = {}); undefined setPriority(double priority); - undefined setPrioritySignalsOverride(DOMString key, double priority); + undefined setPrioritySignalsOverride(DOMString key, optional double? priority); }; dictionary AdRender { @@ -2328,7 +2328,7 @@ Each {{InterestGroupBiddingScriptRunnerGlobalScope}} has a : priority :: Null or a {{double}} : priority signals -:: An [=ordered map=] whose [=map/keys=] are [=strings=] and whose [=map/values=] are {{double}} +:: An [=ordered map=] whose [=map/keys=] are [=strings=] and whose [=map/values=] are {{double}} or null. : interest group :: An [=interest group=] : expected currency