From c1ac7315de484aeaa45b15b752b2b501f563190a Mon Sep 17 00:00:00 2001
From: Keith Cirkel <keithamus@users.noreply.github.com>
Date: Sat, 27 Jul 2024 21:47:10 +0100
Subject: [PATCH 1/3] pass abortsignal reason to close a subscription

---
 spec.bs | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/spec.bs b/spec.bs
index be56646..5ec3264 100644
--- a/spec.bs
+++ b/spec.bs
@@ -37,6 +37,7 @@ urlPrefix: https://dom.spec.whatwg.org; spec: DOM
     for: AbortSignal
       text: dependent signals; url: abortsignal-dependent-signals
       text: signal abort; url:abortsignal-signal-abort
+      text: reason; url:abortsignal-abort-reason
 </pre>
 
 <style>
@@ -262,7 +263,8 @@ The <dfn attribute for=Subscriber><code>signal</code></dfn> getter steps are to
 </div>
 
 <div algorithm>
-  To <dfn>close a subscription</dfn> given a {{Subscriber}} |subscriber|, run these steps:
+  To <dfn>close a subscription</dfn> given a {{Subscriber}} |subscriber|, and
+  an optional {{any}} |reason|, run these steps:
 
     1. If |subscriber|'s [=Subscriber/active=] is false, then return.
 
@@ -292,9 +294,10 @@ observable.subscribe({}, {signal: outerController.signal});
 
     1. Set |subscriber|'s [=Subscriber/active=] boolean to false.
 
-    1. [=AbortSignal/Signal abort=] |subscriber|'s [=Subscriber/subscription controller=].
+    1. [=AbortSignal/Signal abort=] |subscriber|'s [=Subscriber/subscription controller=]
+       with |reason|, if it is given.
 
-       Issue: Abort with an appropriate abort reason.
+       Issue: Abort with an appropriate abort reason if none given.
 
     1. [=list/For each=] |teardown| of |subscriber|'s [=Subscriber/teardown callbacks=] sorted in
        reverse insertion order:
@@ -527,12 +530,14 @@ An <dfn>internal observer</dfn> is a [=struct=] with the following [=struct/item
     1. If |options|'s {{SubscribeOptions/signal}} [=map/exists=], then:
 
        1. If |options|'s {{SubscribeOptions/signal}} is [=AbortSignal/aborted=], then [=close a
-          subscription|close=] |subscriber|.
+          subscription|close=] |subscriber| given |options|'s {{SubscribeOptions/signal}}
+          [=AbortSignal/reason=].
 
        1. Otherwise, [=AbortSignal/add|add the following abort algorithm=] to |options|'s
           {{SubscribeOptions/signal}}:
 
-          1. [=close a subscription|Close=] |subscriber|.
+          1. [=close a subscription|Close=] |subscriber| with |options|'s
+             {{SubscribeOptions/signal}} [=AbortSignal/reason=].
 
     1. If [=this=]'s [=Observable/subscribe callback=] is a {{SubscribeCallback}}, [=invoke=] it
        with |subscriber|.

From 2eaf0f0458f90387f7fb9ef2f288516aa4df43a3 Mon Sep 17 00:00:00 2001
From: Dominic Farolino <domfarolino@gmail.com>
Date: Tue, 13 Aug 2024 19:00:50 +0200
Subject: [PATCH 2/3] Abort reason

---
 spec.bs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/spec.bs b/spec.bs
index 5ec3264..d4358e0 100644
--- a/spec.bs
+++ b/spec.bs
@@ -37,7 +37,7 @@ urlPrefix: https://dom.spec.whatwg.org; spec: DOM
     for: AbortSignal
       text: dependent signals; url: abortsignal-dependent-signals
       text: signal abort; url:abortsignal-signal-abort
-      text: reason; url:abortsignal-abort-reason
+      text: abort reason; url:abortsignal-abort-reason
 </pre>
 
 <style>
@@ -531,13 +531,13 @@ An <dfn>internal observer</dfn> is a [=struct=] with the following [=struct/item
 
        1. If |options|'s {{SubscribeOptions/signal}} is [=AbortSignal/aborted=], then [=close a
           subscription|close=] |subscriber| given |options|'s {{SubscribeOptions/signal}}
-          [=AbortSignal/reason=].
+          [=AbortSignal/abort reason=].
 
        1. Otherwise, [=AbortSignal/add|add the following abort algorithm=] to |options|'s
           {{SubscribeOptions/signal}}:
 
           1. [=close a subscription|Close=] |subscriber| with |options|'s
-             {{SubscribeOptions/signal}} [=AbortSignal/reason=].
+             {{SubscribeOptions/signal}} [=AbortSignal/abort reason=].
 
     1. If [=this=]'s [=Observable/subscribe callback=] is a {{SubscribeCallback}}, [=invoke=] it
        with |subscriber|.

From 7905c52b2e8de8f20d244061ad9c50e5efd83753 Mon Sep 17 00:00:00 2001
From: Dominic Farolino <domfarolino@gmail.com>
Date: Tue, 13 Aug 2024 19:08:01 +0200
Subject: [PATCH 3/3] Abort reason

---
 spec.bs | 2 --
 1 file changed, 2 deletions(-)

diff --git a/spec.bs b/spec.bs
index d4358e0..db7681a 100644
--- a/spec.bs
+++ b/spec.bs
@@ -297,8 +297,6 @@ observable.subscribe({}, {signal: outerController.signal});
     1. [=AbortSignal/Signal abort=] |subscriber|'s [=Subscriber/subscription controller=]
        with |reason|, if it is given.
 
-       Issue: Abort with an appropriate abort reason if none given.
-
     1. [=list/For each=] |teardown| of |subscriber|'s [=Subscriber/teardown callbacks=] sorted in
        reverse insertion order: