From cd8764fec48ccd522f3f233cf5201969b63978d1 Mon Sep 17 00:00:00 2001
From: Marcos Caceres <caceres_m@apple.com>
Date: Thu, 5 Sep 2024 09:39:53 +1000
Subject: [PATCH 1/8] change providers to requests

---
 explainer.md |  2 +-
 index.html   | 24 ++++++++++++------------
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/explainer.md b/explainer.md
index 177acdf..7b75375 100644
--- a/explainer.md
+++ b/explainer.md
@@ -55,7 +55,7 @@ async function requestLicense() {
   };
   const digitalCredential = await navigator.identity.get({
     digital: {
-      providers: [oid4pv],
+      requests: [oid4pv],
     },
   });
   // To be decrypted on the server...
diff --git a/index.html b/index.html
index 086805f..a191c1f 100644
--- a/index.html
+++ b/index.html
@@ -189,29 +189,29 @@ <h2>
     </h2>
     <pre class="idl">
     dictionary DigitalCredentialRequestOptions {
-      sequence&lt;DigitalCredentialsProvider&gt; providers;
+      sequence&lt;DigitalCredentialsProvider&gt; requests;
     };
     </pre>
     <h3>
-      The `providers` member
+      The `requests` member
     </h3>
     <p>
-      The <dfn data-dfn-for="DigitalCredentialRequestOptions">providers</dfn>
+      The <dfn data-dfn-for="DigitalCredentialRequestOptions">requests</dfn>
       specify an [=digital credential/exchange protocol=] and [=digital
       credential/query=], which the user agent MAY match against a holder's
       software, such as a digital wallet.
     </p>
     <h2>
-      The `DigitalCredentialsProvider` dictionary
+      The `DigitalCredentialsRequest` dictionary
     </h2>
     <p>
-      The {{DigitalCredentialsProvider}} dictionary is used to specify an
+      The {{DigitalCredentialsRequest}} dictionary is used to specify an
       [=digital credential/exchange protocol=] and a [=digital
       credential/query=], which the user agent MAY match against software used
       by a holder, such as a digital wallet.
     </p>
     <pre class="idl">
-    dictionary DigitalCredentialsProvider {
+    dictionary DigitalCredentialsRequest {
       required DOMString protocol;
       required object request;
     };
@@ -220,12 +220,12 @@ <h3>
       The `protocol` member
     </h3>
     <p>
-      The <dfn data-dfn-for="DigitalCredentialsProvider">protocol</dfn> member
+      The <dfn data-dfn-for="DigitalCredentialsRequest">protocol</dfn> member
       denotes the [=digital credential/exchange protocol=] when requesting an
       identify credential.
     </p>
     <p>
-      The {{DigitalCredentialsProvider/protocol}} member's value is be one of
+      The {{DigitalCredentialsRequest/protocol}} member's value is be one of
       the well-defined keys defined in [[[#protocol-registry]]] or any other
       custom one.
     </p>
@@ -233,7 +233,7 @@ <h3>
       The `request` member
     </h3>
     <p>
-      The <dfn data-dfn-for="DigitalCredentialsProvider">request</dfn> member
+      The <dfn data-dfn-for="DigitalCredentialsRequest">request</dfn> member
       is the request to be handled by the holder's software, such as a digital
       wallet.
     </p>
@@ -308,10 +308,10 @@ <h3>
       </li>
       <li>[=Consume user activation=] of |window|.
       </li>
-      <li>Let |providers| be |options|'s {{CredentialRequestOptions/digital}}'s
-      {{DigitalCredentialRequestOptions/providers}} member.
+      <li>Let |requests| be |options|'s {{CredentialRequestOptions/digital}}'s
+      {{DigitalCredentialRequestOptions/requests}} member.
       </li>
-      <li>If |providers| is empty, [=exception/throw=] a {{TypeError}}.
+      <li>If |requests| is empty, [=exception/throw=] a {{TypeError}}.
       </li>
       <li>
         <aside class="issue">

From a71f81285de16b9ad27d684e7376e918736213ba Mon Sep 17 00:00:00 2001
From: Marcos Caceres <caceres_m@apple.com>
Date: Mon, 16 Sep 2024 16:20:44 -0600
Subject: [PATCH 2/8] user request and data

---
 index.html | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/index.html b/index.html
index a191c1f..8a57108 100644
--- a/index.html
+++ b/index.html
@@ -189,7 +189,7 @@ <h2>
     </h2>
     <pre class="idl">
     dictionary DigitalCredentialRequestOptions {
-      sequence&lt;DigitalCredentialsProvider&gt; requests;
+      sequence&lt;DigitalCredentialsRequest&gt; requests;
     };
     </pre>
     <h3>
@@ -213,7 +213,7 @@ <h2>
     <pre class="idl">
     dictionary DigitalCredentialsRequest {
       required DOMString protocol;
-      required object request;
+      required object data;
     };
     </pre>
     <h3>
@@ -230,12 +230,12 @@ <h3>
       custom one.
     </p>
     <h3>
-      The `request` member
+      The `data` member
     </h3>
     <p>
-      The <dfn data-dfn-for="DigitalCredentialsRequest">request</dfn> member
-      is the request to be handled by the holder's software, such as a digital
-      wallet.
+      The <dfn data-dfn-for="DigitalCredentialsRequest">data</dfn> member is
+      the [=digital credential/query=] to be handled by the holder's software,
+      such as a digital wallet.
     </p>
     <h2>
       The `DigitalCredential` interface

From 29baf585a3db5ac9f47730bbaebcd134d148b840 Mon Sep 17 00:00:00 2001
From: Marcos Caceres <caceres_m@apple.com>
Date: Mon, 16 Sep 2024 16:41:55 -0600
Subject: [PATCH 3/8] request data in model

---
 index.html | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/index.html b/index.html
index 8a57108..336714f 100644
--- a/index.html
+++ b/index.html
@@ -101,7 +101,7 @@ <h2>
         </p>
       </dd>
       <dt>
-        <dfn data-dfn-for="digital credential">query</dfn>
+        <dfn data-dfn-for="digital credential">request data</dfn>
       </dt>
       <dd>
         A format that [=verifier=] software or a [=user agent=] uses, via an
@@ -114,7 +114,7 @@ <h2>
       <dd>
         A format that a [=holder|holder's=] software, such as a digital wallet,
         uses, via an [=digital credential/exchange protocol=], to respond to a
-        [=digital credential/query=] by a [=verifier=].
+        [=digital credential/request data=] by a [=verifier=].
       </dd>
       <dt>
         <dfn data-dfn-for="digital credential">Exchange protocol</dfn>
@@ -198,8 +198,8 @@ <h3>
     <p>
       The <dfn data-dfn-for="DigitalCredentialRequestOptions">requests</dfn>
       specify an [=digital credential/exchange protocol=] and [=digital
-      credential/query=], which the user agent MAY match against a holder's
-      software, such as a digital wallet.
+      credential/request data=], which the user agent MAY match against a
+      holder's software, such as a digital wallet.
     </p>
     <h2>
       The `DigitalCredentialsRequest` dictionary
@@ -207,8 +207,8 @@ <h2>
     <p>
       The {{DigitalCredentialsRequest}} dictionary is used to specify an
       [=digital credential/exchange protocol=] and a [=digital
-      credential/query=], which the user agent MAY match against software used
-      by a holder, such as a digital wallet.
+      credential/request data=], which the user agent MAY match against
+      software used by a holder, such as a digital wallet.
     </p>
     <pre class="idl">
     dictionary DigitalCredentialsRequest {
@@ -234,8 +234,8 @@ <h3>
     </h3>
     <p>
       The <dfn data-dfn-for="DigitalCredentialsRequest">data</dfn> member is
-      the [=digital credential/query=] to be handled by the holder's software,
-      such as a digital wallet.
+      the [=digital credential/request data=] to be handled by the holder's
+      software, such as a digital wallet.
     </p>
     <h2>
       The `DigitalCredential` interface

From 479db4f41e1f9a36d117e97f4b597982e0ddc0f4 Mon Sep 17 00:00:00 2001
From: Marcos Caceres <caceres_m@apple.com>
Date: Mon, 16 Sep 2024 16:48:26 -0600
Subject: [PATCH 4/8] add presentation request

---
 index.html | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/index.html b/index.html
index 336714f..261cb59 100644
--- a/index.html
+++ b/index.html
@@ -100,6 +100,14 @@ <h2>
           pertaining to people.
         </p>
       </dd>
+      <dt>
+        <dfn>Presentation request</dfn>
+      </dt>
+      <dd>
+        A presentation request is a request for a digital credential composed
+        of [=digital credential/request data=] and a [=digital
+        credential/exchange protocol=].
+      </dd>
       <dt>
         <dfn data-dfn-for="digital credential">request data</dfn>
       </dt>
@@ -205,10 +213,11 @@ <h2>
       The `DigitalCredentialsRequest` dictionary
     </h2>
     <p>
-      The {{DigitalCredentialsRequest}} dictionary is used to specify an
-      [=digital credential/exchange protocol=] and a [=digital
-      credential/request data=], which the user agent MAY match against
-      software used by a holder, such as a digital wallet.
+      The {{DigitalCredentialsRequest}} dictionary represents a [=presentation
+      request]. It is used to specify an [=digital credential/exchange
+      protocol=] and a [=digital credential/request data=], which the user
+      agent MAY match against software used by a holder, such as a digital
+      wallet.
     </p>
     <pre class="idl">
     dictionary DigitalCredentialsRequest {

From 1c25a5487278314828d3595354589e66542bc15b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= <marcosc@apple.com>
Date: Mon, 16 Sep 2024 16:49:29 -0600
Subject: [PATCH 5/8] Update index.html

---
 index.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/index.html b/index.html
index 261cb59..0f8df8c 100644
--- a/index.html
+++ b/index.html
@@ -101,7 +101,7 @@ <h2>
         </p>
       </dd>
       <dt>
-        <dfn>Presentation request</dfn>
+        <dfn data-dfn-for="digital credential">Presentation request</dfn>
       </dt>
       <dd>
         A presentation request is a request for a digital credential composed

From bf803e3ef3d670c20dc587ea6c5ae419a7984467 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= <marcosc@apple.com>
Date: Mon, 16 Sep 2024 16:49:40 -0600
Subject: [PATCH 6/8] Update index.html

Co-authored-by: Sam Goto <samuelgoto@gmail.com>
---
 index.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/index.html b/index.html
index 0f8df8c..82ed94c 100644
--- a/index.html
+++ b/index.html
@@ -104,7 +104,7 @@ <h2>
         <dfn data-dfn-for="digital credential">Presentation request</dfn>
       </dt>
       <dd>
-        A presentation request is a request for a digital credential composed
+        A presentation request is a request for a [=digital credential=] composed
         of [=digital credential/request data=] and a [=digital
         credential/exchange protocol=].
       </dd>

From df671d626461f8cd76c2b28e3171b515b514deaa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= <marcosc@apple.com>
Date: Mon, 16 Sep 2024 16:50:34 -0600
Subject: [PATCH 7/8] Update index.html

---
 index.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/index.html b/index.html
index 82ed94c..5a0ad6e 100644
--- a/index.html
+++ b/index.html
@@ -213,8 +213,8 @@ <h2>
       The `DigitalCredentialsRequest` dictionary
     </h2>
     <p>
-      The {{DigitalCredentialsRequest}} dictionary represents a [=presentation
-      request]. It is used to specify an [=digital credential/exchange
+      The {{DigitalCredentialsRequest}} dictionary represents a [=digital credential/presentation
+      request=]. It is used to specify an [=digital credential/exchange
       protocol=] and a [=digital credential/request data=], which the user
       agent MAY match against software used by a holder, such as a digital
       wallet.

From 48f6041805a10de68a6130bfcb6b9f08cc4cf0e5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= <marcosc@apple.com>
Date: Wed, 18 Sep 2024 17:14:00 -0600
Subject: [PATCH 8/8] Update explainer.md

---
 explainer.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/explainer.md b/explainer.md
index 7b75375..54a0893 100644
--- a/explainer.md
+++ b/explainer.md
@@ -46,7 +46,7 @@ async function requestLicense() {
   const oid4pv = {
     // Protocol extensibility:
     protocol: "oid4vp", // An example of an OpenID4VP request to wallets. // Based on https://github.com/openid/OpenID4VP/issues/125
-    request: {
+    data: {
       nonce: "n-0S6_WzA2Mj",
       presentation_definition: {
         // Presentation Exchange request, omitted for brevity