Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make cruise parameter on all endpoints case-insensitive #108

Open
joefutrelle opened this issue Aug 28, 2023 · 2 comments
Open

make cruise parameter on all endpoints case-insensitive #108

joefutrelle opened this issue Aug 28, 2023 · 2 comments
Assignees
@joefutrelle
Labels
enhancement New feature or request

Comments

@joefutrelle
Copy link
Contributor

This issue showed up with cruise IDs
@joefutrelle joefutrelle added the enhancement New feature or request label Aug 28, 2023
@joefutrelle joefutrelle self-assigned this Aug 28, 2023
@joefutrelle joefutrelle changed the title make all endpoint parameters case-insensitive make cruise parameter on all endpoints case-insensitive Aug 28, 2023
@joefutrelle
Copy link
Contributor Author

joefutrelle commented Aug 28, 2023 •
edited
Loading

This bug currently affects a limited set of endpoints and workflow steps:

Unless there are issues with mixed-case inputs to these workflows, these need to be changed to self.cruise = cruise.lower()

@joefutrelle joefutrelle mentioned this issue Aug 29, 2023
Merged
@katemorkeski
Copy link

Some examples of endpoints that don't work: https://nes-lter-data.whoi.edu/api/underway/AR31A.csv, https://nes-lter-data.whoi.edu/api/underway/EN617.csv, https://nes-lter-data.whoi.edu/api/underway/EN655.csv, in contrast to having the cruise names in lowercase (which works).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joefutrelle joefutrelle

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joefutrelle @katemorkeski