Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a curation page for /chemical/ #2308

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

egonw
Copy link
Collaborator

@egonw egonw commented Jul 23, 2023

Description

Curation page for chemicals.

chemical name in article titles

image

missing chemical properties

image

Caveats

Check any of the following which apply:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

If you make changes to the Python code

  • My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@egonw egonw self-assigned this Jul 23, 2023
@egonw egonw removed their assignment Jul 23, 2023
@egonw egonw added the enhancement some suggestions to improve Scholia label Jul 23, 2023
@egonw egonw marked this pull request as ready for review July 23, 2023 13:06
@Adafede
Copy link
Contributor

Adafede commented Jul 23, 2023

Obvious support for this one! Thank you very much @egonw 💪🏼

@fnielsen fnielsen merged commit af9c4e0 into WDscholia:master Oct 20, 2023
4 checks passed
@fnielsen
Copy link
Collaborator

I have now merge this into master. @egonw and I discussed whether clinical trials should have P921 when it is represented in another way, see, e.g., https://www.wikidata.org/w/index.php?title=Q62105803&oldid=1993994468

@fnielsen
Copy link
Collaborator

As stated on #2352 the link for work goes to chemical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement some suggestions to improve Scholia
Projects
3 participants