Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ORCID URL after structure was changed #2298

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

carlinmack
Copy link
Collaborator

Fixing same issue as Daniel's PR here arthurpsmith/author-disambiguator#187

Description

Please include a summary of the change, relevant motivation and context. If possible and applicable, include before and after screenshots and a URL where the changes can be seen.

ORCID changed their search URL so we need to use a different structure. I searched for all occurrences in the repository and fixed them

Caveats

Please list anything which has been left out of this PR or which should be considered before this PR is accepted
Check any of the following which apply:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

If you make changes to the Python code

  • My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@egonw egonw self-requested a review July 15, 2023 08:24
Copy link
Collaborator

@egonw egonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the problem and the solution from this PR with https://scholia.toolforge.org/dataset/Q4203254

Looks good to me!

@egonw egonw added bug something wrong on our end P496-ORCID Wikidata property max-5-lines Tag for pull requests to indicate the changes are at most 5 lines changed ready for merge label to flag a pull request ready for decision by the gatekeeper for merge into master labels Jul 15, 2023
@fnielsen
Copy link
Collaborator

fnielsen commented Jul 27, 2023

@fnielsen fnielsen merged commit 7d1dc52 into WDscholia:master Jul 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something wrong on our end max-5-lines Tag for pull requests to indicate the changes are at most 5 lines changed P496-ORCID Wikidata property ready for merge label to flag a pull request ready for decision by the gatekeeper for merge into master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants