Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Manager hangs if an update command is sent with a wrong configuration file #211

Closed
frikilax opened this issue Nov 10, 2020 · 1 comment · Fixed by #217
Closed

[BUG] Manager hangs if an update command is sent with a wrong configuration file #211

frikilax opened this issue Nov 10, 2020 · 1 comment · Fixed by #217
Labels
bug Something isn't working
Milestone
Version 1.5.0

Comments

@frikilax
Copy link
Member

Describe the bug
if an error is put in the manager configuration file, and the manager is reloaded with an admin command, the parsing of the configuration file fails and the manager hangs after sending a critical error

Plateform (please complete the following information):

  • OS (version): HBSD12.2
  • Darwin version: 1.4

To Reproduce
Steps to reproduce the behavior:

  1. Setup a correct configuration file (with a single running filter for example)
  2. Run Darwin, the manager and the filter should work correctly
  3. Modify the configuration file, so that it is not a valid json (add characters at the beginning of the file, for example)
  4. send a {"type": "update_filters"} command to the manager
  5. netcat should hang indefinitely, and darwin_manager.log should show a CRITICAL log

Expected behavior
Manager should invalidate the configuration file, but shouldn't fail and hang after reading it, its state should remain the same.

Screenshots/logs
image
image
@frikilax frikilax added the bug Something isn't working label Nov 10, 2020
@frikilax frikilax added this to the Version 1.5.0 milestone Nov 10, 2020
frikilax added a commit that referenced this issue Feb 2, 2021
@frikilax
MANAGER:: DON'T CRASH ON WRONG FORMATTING IN MANAGER CONF (RESOLVE #211)
9549e7c 
# MANAGER
- handle exceptions correctly when parsing manager conf file, especially for json formatting

# TESTS
- add tests to manager with wrong json format in manager conf file
@frikilax frikilax mentioned this issue Feb 11, 2021
Merged
7 tasks
@frikilax frikilax linked a pull request Feb 23, 2021 that will close this issue
Avoid Manager crashing when updating a configuration with syntax errors #217
Merged
7 tasks
@HugoSoszynski
Copy link
Contributor

Closed by #217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Version 1.5.0
Development

Successfully merging a pull request may close this issue.

Avoid Manager crashing when updating a configuration with syntax errors VultureProject/darwin
2 participants
@HugoSoszynski @frikilax