[IDEA] Test for SOFA #151
Comments
HugoSoszynski
added a commit
that referenced
this issue
Jan 15, 2020
# ✨ Pull Request Template‼️ Once all the **checklist** is **done** you have to: * **stash merge** this pull request * **delete** the corresponding **branch** * **close** the associated **issue** ## 📃 Type of change **New feature**: non-breaking change which adds functionality. ## 💡 Related Issue(s) Resolve: #151 ## ✒️ Description Sofa algorithm implementation is functional and provided with a default configuration file. This algorithm is not open-source and will be used in a unique setup requiring the non generic development. Because of the unusual nature of the data returned by the algorithm it needs to override the Session's method for sending back response to the client. Because the python code called by the filter has to keep all the data in memory we write it on disk so we free up our memory space. This filter is not made for real-time so memory optimization is preferred. The files are written in `/var/tmp` for production purposes and deleted when a task finished running. **CAUTION: This filter is made to run on ONE THREAD ONLY!** Overloaded sending method to send back results to the client because the extensive nature of the results do not allow to use the standard method. _NOTE: the new filter is not compiled by default._ **Misc.** - Updated FileManager to be able to disable opening retry on failure. - Corrected compilation for finspection. ## 🎯 Test Environments ### FreeBSD 12.1 - Redis 5.0.7 - Boost 1.71.0 - clang++ 8.0.1 - CMake 3.15.3 - Python 3.6.9 ### Ubuntu 19.4 - Redis 5.0.3 - Boost 1.71.0 - g++ 8.3.0 - CMake 3.13.4 - Python 3.7.3 ## ✔️ Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added corresponding page to the documentation - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes </br> - [x] 🙋 **I certify on my honor that all the information provided is true, and I've done all I can to deliver a high quality code**
HugoSoszynski
added a commit
that referenced
this issue
Feb 7, 2020
# ✨ Pull Request Template‼️ Once all the **checklist** is **done** you have to: * **stash merge** this pull request * **delete** the corresponding **branch** * **close** the associated **issue** ## 📃 Type of change **New feature**: non-breaking change which adds functionality. ## 💡 Related Issue(s) Resolve: #151 ## ✒️ Description Sofa algorithm implementation is functional and provided with a default configuration file. This algorithm is not open-source and will be used in a unique setup requiring the non generic development. Because of the unusual nature of the data returned by the algorithm it needs to override the Session's method for sending back response to the client. Because the python code called by the filter has to keep all the data in memory we write it on disk so we free up our memory space. This filter is not made for real-time so memory optimization is preferred. The files are written in `/var/tmp` for production purposes and deleted when a task finished running. **CAUTION: This filter is made to run on ONE THREAD ONLY!** Overloaded sending method to send back results to the client because the extensive nature of the results do not allow to use the standard method. _NOTE: the new filter is not compiled by default._ **Misc.** - Updated FileManager to be able to disable opening retry on failure. - Corrected compilation for finspection. ## 🎯 Test Environments ### FreeBSD 12.1 - Redis 5.0.7 - Boost 1.71.0 - clang++ 8.0.1 - CMake 3.15.3 - Python 3.6.9 ### Ubuntu 19.4 - Redis 5.0.3 - Boost 1.71.0 - g++ 8.3.0 - CMake 3.13.4 - Python 3.7.3 ## ✔️ Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added corresponding page to the documentation - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes </br> - [x] 🙋 **I certify on my honor that all the information provided is true, and I've done all I can to deliver a high quality code**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is your feature about ?
Need automated test for SOFA filter
https://github.com/VultureProject/darwin/wiki/Filter-Sofa
Describe what you'd like
Test must be passed on Ubuntu and FreeBSD
The text was updated successfully, but these errors were encountered: