Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONFV2:: NEW CONF FORMAT, CONF VALIDATION, TESTS #139

Merged
merged 1 commit into from
Dec 2, 2019
Merged

CONFV2:: NEW CONF FORMAT, CONF VALIDATION, TESTS #139

merged 1 commit into from
Dec 2, 2019

Conversation

frikilax
Copy link
Member

@frikilax frikilax commented Nov 29, 2019 •
edited
Loading

✨ Pull Request Template

‼️ Once all the checklist is done you have to:

  • stash merge this pull request
  • delete the corresponding branch
  • close the associated issue

📃 Type of change

Please delete options that are not relevant.

New feature: non-breaking change which adds functionality.
Breaking change: fix or feature that would cause existing functionality to not work as expected.

💡 Related Issue(s)

✒️ Description

New configuration format created for the darwin manager (darwin.conf).
Validation of darwin.conf files made ith jsonschema.
(Relevant) existing tests added for the v2 format.

🎯 Test Environments

FreeBSD 12.0

  • Python 3.6
  • new python module: jsonschema 3.2.0

Ubuntu 18.04

  • Python 3.6
  • new python module: jsonschema 3.2.0

✔️ Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • (If other changes) I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

  • 🙋 I certify on my honor that all the information provided is true, and I've done all I can to deliver a high quality code

@frikilax frikilax added enhancement New feature or request important tests labels Nov 29, 2019
@frikilax frikilax added this to the Version 1.2 milestone Nov 29, 2019
@frikilax frikilax self-assigned this Nov 29, 2019
@frikilax
CONFV2:: NEW CONF FORMAT, CONF VALIDATION, TESTS
264755f 
- update to python files' header (removed Vulture-specific headers)
- new configuration format (conf v2) implemented
  - possibility to add objects in json for general manager/Darwin mechanics
  - no more variable object names in conf -> filters are self-contained in a list, with the name as a regular field
- configuration files validation via jsonschema
- new tests for conf v2
- added requirements.txt
HugoSoszynski
HugoSoszynski suggested changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@HugoSoszynski HugoSoszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the requirements.txt and update the wiki

@HugoSoszynski HugoSoszynski self-requested a review December 2, 2019 16:10
@frikilax frikilax merged commit b863b27 into dev Dec 2, 2019
@frikilax frikilax deleted the feature-conf_v2 branch December 2, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HugoSoszynski HugoSoszynski HugoSoszynski approved these changes

@NS4nti NS4nti Awaiting requested review from NS4nti

Assignees

@frikilax frikilax

Labels
enhancement New feature or request important tests
Projects
None yet
Milestone
Version 1.2
Development

Successfully merging this pull request may close these issues.

[IDEA] Implement new darwin.conf format version
2 participants
@frikilax @HugoSoszynski