Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IDEA] Implement new darwin.conf format version #137

Closed
frikilax opened this issue Nov 27, 2019 · 0 comments · Fixed by #139
Closed

[IDEA] Implement new darwin.conf format version #137

frikilax opened this issue Nov 27, 2019 · 0 comments · Fixed by #139
Assignees
@frikilax
Labels
enhancement New feature or request important
Milestone
Version 1.2

Comments

@frikilax
Copy link
Member

What is your feature about ?
Implement a new format/version for Darwin general configuration file.

Describe what you'd like
The current Darwin configuration general file allows only to configure filters, the idea for a new version comes from the need to configure general mechanics for Darwin filters (alerting, stats reporting...)

Additional context
Darwin should be able to read 'old' and 'new' version formats
@frikilax frikilax added the enhancement New feature or request label Nov 27, 2019
@frikilax frikilax self-assigned this Nov 27, 2019
@frikilax frikilax added this to the Version 1.2 milestone Nov 27, 2019
@frikilax frikilax mentioned this issue Nov 29, 2019
Merged
7 tasks
frikilax added a commit that referenced this issue Dec 2, 2019
@frikilax
CONFV2:: NEW CONF FORMAT, CONF VALIDATION, TESTS (#139)
b863b27 
# ✨ Pull Request Template
‼️ Once all the **checklist** is **done** you have to:
  * **stash merge** this pull request
  * **delete** the corresponding **branch**
  * **close** the associated **issue**

## 📃 Type of change

Please delete options that are not relevant.

**New feature**: non-breaking change which adds functionality.
**Breaking change**: fix or feature that would cause existing functionality to not work as expected.

## 💡 Related Issue(s)

- Resolve #137 

## ✒️ Description
New configuration format created for the darwin manager (darwin.conf).
Validation of darwin.conf files made ith jsonschema.
(Relevant) existing tests added for the v2 format.

- update to python files' header (removed Vulture-specific headers)
- new configuration format (conf v2) implemented
  - possibility to add objects in json for general manager/Darwin mechanics
  - no more variable object names in conf -> filters are self-contained in a list, with the name as a regular field
- configuration files validation via jsonschema
- new tests for conf v2
- added requirements.txt

## 🎯 Test Environments

### FreeBSD 12.0
- Python 3.6
- new python module: jsonschema 3.2.0

### Ubuntu 18.04
- Python 3.6
- new python module: jsonschema 3.2.0

## ✔️ Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] (**If other changes**) I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes

</br>

- [x] 🙋 **I certify on my honor that all the information provided is true, and I've done all I can to deliver a high quality code**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frikilax frikilax

Labels
enhancement New feature or request important
Projects
None yet
Milestone
Version 1.2
Development

Successfully merging a pull request may close this issue.

CONFV2:: NEW CONF FORMAT, CONF VALIDATION, TESTS VultureProject/darwin
1 participant
@frikilax