[IDEA] Test for fanomaly #106
Comments
HugoSoszynski
pushed a commit
that referenced
this issue
Jan 6, 2020
# ✨ Pull Request Template‼️ Once all the **checklist** is **done** you have to: * **stash merge** this pull request * **delete** the corresponding **branch** * **close** the associated **issue** * **move** ANOMALY in [TESTED AND APPROVED](https://github.com/VultureProject/darwin/wiki/Filters-Summary) section ## 📃 Type of change **New feature**: non-breaking change which adds functionality. ## 💡 Related Issue(s) - Resolve #106 ## ✒️ Description Tests for anomaly filter : - not_enough_data_test - no_data_list_test (if the data provided is not a list of list, but just some lists) - line_too_short_test - line_no_string_test - line_no_int_test - line_no_data_list_test - one_set_data_test - multiple_set_data_test ## 🎯 Test Environments ### FreeBSD 12.0 - clang++ 6.0.1 - CMake 3.7.2 - Python 3 ### Ubuntu 19.0.4 - g++ 8.3.0 - CMake 3.7.2 - Python 3 Valgrind test don't pass because of memory leak in the mlpack library : ``` ==1294== 352 bytes in 2 blocks are definitely lost in loss record 2 of 2 ==1294== at 0x4838DBF: operator new(unsigned long) (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so) ==1294== by 0x19485C: mlpack::range::RangeSearch<mlpack::metric::LMetric<2, true>, arma::Mat<double>, mlpack::tree::KDTree>::RangeSearch(bool, bool, mlpack::metric::LMetric<2, true>) (range_search_impl.hpp:100) ==1294== by 0x19002F: AnomalyTask::Detection() (AnomalyTask.cpp:62) ``` ## ✔️ Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes </br> - [x] 🙋 **I certify on my honor that all the information provided is true, and I've done all I can to deliver a high quality code**
HugoSoszynski
pushed a commit
that referenced
this issue
Feb 7, 2020
# ✨ Pull Request Template‼️ Once all the **checklist** is **done** you have to: * **stash merge** this pull request * **delete** the corresponding **branch** * **close** the associated **issue** * **move** ANOMALY in [TESTED AND APPROVED](https://github.com/VultureProject/darwin/wiki/Filters-Summary) section ## 📃 Type of change **New feature**: non-breaking change which adds functionality. ## 💡 Related Issue(s) - Resolve #106 ## ✒️ Description Tests for anomaly filter : - not_enough_data_test - no_data_list_test (if the data provided is not a list of list, but just some lists) - line_too_short_test - line_no_string_test - line_no_int_test - line_no_data_list_test - one_set_data_test - multiple_set_data_test ## 🎯 Test Environments ### FreeBSD 12.0 - clang++ 6.0.1 - CMake 3.7.2 - Python 3 ### Ubuntu 19.0.4 - g++ 8.3.0 - CMake 3.7.2 - Python 3 Valgrind test don't pass because of memory leak in the mlpack library : ``` ==1294== 352 bytes in 2 blocks are definitely lost in loss record 2 of 2 ==1294== at 0x4838DBF: operator new(unsigned long) (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so) ==1294== by 0x19485C: mlpack::range::RangeSearch<mlpack::metric::LMetric<2, true>, arma::Mat<double>, mlpack::tree::KDTree>::RangeSearch(bool, bool, mlpack::metric::LMetric<2, true>) (range_search_impl.hpp:100) ==1294== by 0x19002F: AnomalyTask::Detection() (AnomalyTask.cpp:62) ``` ## ✔️ Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes </br> - [x] 🙋 **I certify on my honor that all the information provided is true, and I've done all I can to deliver a high quality code**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is your feature about ?
Need to add automated test for anomaly
Describe what you'd like
Test must be tested on Ubuntu and FreeBSD
The text was updated successfully, but these errors were encountered: