-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow "database" in config for mysql connections #161
Comments
I will try my best to see what I can do for that |
@4Kaylum when you're awake, please elaborate on which part it requires "database". Are you talking about item names in objects sent to the API? or are you talking about variables? |
The current VBU config file takes in database connection options with the "database" key. The "db" key should be considered an alias/alternative to this key. If both are supplied, which one should take over the other? |
Ideally, the last one that is defined in a file so they would overwrite each other but maybe "database" if checking for the last one in a file is not a possibility as "database" is just longer and more noticeable in a large configuration file. |
honestly the config should just stay as only allowing "database" and just parse it differently for msql connections |
Fixes Voxel-Fox-Ltd#161 I'm unsure if `del`eting the old key will have unintended consequences...
Aiomysql requires "db" instead of "database". VBU should allow both.
The text was updated successfully, but these errors were encountered: