Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Signed SMS Environment Variables #51

Open
dragonmantank opened this issue Sep 8, 2020 · 2 comments
Open

Add Signed SMS Environment Variables #51

dragonmantank opened this issue Sep 8, 2020 · 2 comments
Labels
good first issue hacktoberfest

Comments

@dragonmantank
Copy link
Contributor

We need to add FROM_NUMBER and VONAGE_API_SIGNATURE_SECRET to the .env-example file so that they can be set when users run sms/send-signed-sms.php
@dragonmantank dragonmantank mentioned this issue Sep 8, 2020
Merged
@moisesortega
Copy link

Hi, I'm fairly new to open source, and I was wondering if I could work on this for Hacktoberfest?

@dragonmantank
Copy link
Contributor Author

Of course! Any help is welcomed!

gthoffer added a commit to gthoffer/vonage-php-code-snippets that referenced this issue Oct 2, 2020
@gthoffer
Fix issue Vonage#51: add environment variable placeholders for FROM_N…
13ceb76 
…UMBER and VONAGE_API_SIGNATURE_SECRET so things work when running sms/send-signed-sms.php
@gthoffer gthoffer mentioned this issue Oct 2, 2020
Open
gthoffer added a commit to gthoffer/vonage-php-code-snippets that referenced this issue Oct 5, 2020
@gthoffer
51 signed sms env vars (#1)
867c98c 
* Fix issue Vonage#51: add environment variable placeholders for FROM_NUMBER and VONAGE_API_SIGNATURE_SECRET so things work when running sms/send-signed-sms.php

* Fix Vonage#52 - cast 'NUMBER_SEARCH_CRITERIA' as (string).  Added comment to caution use of criteria starting with '0' to avoid conversion-to-octal issues.  Added some more comments while I was at it to help users understand the use of the filter object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dragonmantank @moisesortega