Skip to content

Commit 341ddd1

Browse files
committed
fix: Misc warnings & failures
1 parent 6408342 commit 341ddd1

18 files changed

+45
-36
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ need a Vonage account. You'll need to have [created a Vonage account](https://da
2323

2424
- [Account](https://developer.vonage.com/en/account/overview)
2525
- [Application](https://developer.vonage.com/en/application/overview)
26+
- [Conversion](https://developer.vonage.com/messaging/conversion-api/overview)
2627
- [Meetings](https://developer.vonage.com/en/meetings/overview)
2728
- [Messages](https://developer.vonage.com/en/messages/overview)
2829
- [Number Insight](https://developer.vonage.com/en/number-insight/overview)

src/main/java/com/vonage/client/DynamicEndpoint.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,11 @@
2323
import org.apache.http.entity.ContentType;
2424
import org.apache.http.entity.StringEntity;
2525
import org.apache.http.util.EntityUtils;
26-
2726
import java.io.IOException;
2827
import java.io.UnsupportedEncodingException;
2928
import java.lang.reflect.Constructor;
3029
import java.lang.reflect.InvocationTargetException;
3130
import java.lang.reflect.Modifier;
32-
import java.net.URI;
3331
import java.util.ArrayList;
3432
import java.util.Arrays;
3533
import java.util.Collection;
@@ -195,7 +193,7 @@ else if (v instanceof Iterable<?>) {
195193
else if (requestBody instanceof byte[]) {
196194
rqb.setEntity(new ByteArrayEntity((byte[]) requestBody));
197195
}
198-
return rqb.setUri(URI.create(pathGetter.apply(this, requestBody)));
196+
return rqb.setUri(pathGetter.apply(this, requestBody));
199197
}
200198

201199
protected R parseResponseFromString(String response) {

src/main/java/com/vonage/client/account/Network.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public String getName() {
5757
return name;
5858
}
5959

60-
enum Type {
60+
public enum Type {
6161
MOBILE, LANDLINE, PAGER, LANDLINE_TOLLFREE, UNKNOWN;
6262

6363
@Override

src/main/java/com/vonage/client/insight/AdvancedInsightRequest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public Map<String, String> makeParams() {
100100
*
101101
* @param number A single phone number that you need insight about in national or international format.
102102
*
103-
* @return A new {@link AdvancedInsightRequest} object.
103+
* @return A new AdvancedInsightRequest object.
104104
*/
105105
public static AdvancedInsightRequest withNumber(String number) {
106106
return new Builder(number).build();
@@ -112,7 +112,7 @@ public static AdvancedInsightRequest withNumber(String number) {
112112
* @param number A single phone number that you need insight about in national or international format.
113113
* @param country If a number does not have a country code, or it is uncertain, set the two-character country code.
114114
*
115-
* @return A new {@link AdvancedInsightRequest} object.
115+
* @return A new AdvancedInsightRequest object.
116116
*/
117117
public static AdvancedInsightRequest withNumberAndCountry(String number, String country) {
118118
return new Builder(number).country(country).build();

src/main/java/com/vonage/client/insight/BasicInsightRequest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ private BasicInsightRequest(Builder builder) {
2626
*
2727
* @param number A single phone number that you need insight about in national or international format.
2828
*
29-
* @return A new {@link BasicInsightRequest} object.
29+
* @return A new BasicInsightRequest object.
3030
*/
3131
public static BasicInsightRequest withNumber(String number) {
3232
return new Builder(number).build();
@@ -38,7 +38,7 @@ public static BasicInsightRequest withNumber(String number) {
3838
* @param number A single phone number that you need insight about in national or international format.
3939
* @param country If a number does not have a country code, or it is uncertain, set the two-character country code.
4040
*
41-
* @return A new {@link BasicInsightRequest} object.
41+
* @return A new BasicInsightRequest object.
4242
*/
4343
public static BasicInsightRequest withNumberAndCountry(String number, String country) {
4444
return new Builder(number).country(country).build();

src/main/java/com/vonage/client/insight/InsightStatus.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public enum InsightStatus {
6868
}
6969

7070
/**
71-
* Look up the {@link InsightStatus} based on the int value.
71+
* Look up the InsightStatus based on the int value.
7272
*
7373
* @param insightStatus the integer value of the insight status.
7474
* @return InsightStatus based on the int value given.

src/main/java/com/vonage/client/insight/StandardInsightRequest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public Boolean getCnam() {
3131
*
3232
* @param number A single phone number that you need insight about in national or international format.
3333
*
34-
* @return A new {@link StandardInsightRequest} object.
34+
* @return A new StandardInsightRequest object.
3535
*/
3636
public static StandardInsightRequest withNumber(String number) {
3737
return new Builder(number).build();
@@ -43,7 +43,7 @@ public static StandardInsightRequest withNumber(String number) {
4343
* @param number A single phone number that you need insight about in national or international format.
4444
* @param country If a number does not have a country code or it is uncertain, set the two-character country code.
4545
*
46-
* @return A new {@link StandardInsightRequest} object.
46+
* @return A new StandardInsightRequest object.
4747
*/
4848
public static StandardInsightRequest withNumberAndCountry(String number, String country) {
4949
return new Builder(number).country(country).build();

src/main/java/com/vonage/client/sms/MessageStatus.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ public enum MessageStatus {
178178
));
179179

180180
/**
181-
* Look up the {@link MessageStatus} based on the int value.
181+
* Look up the MessageStatus based on the int value.
182182
*
183183
* @param messageStatus the int value of the message status.
184184
*

src/main/java/com/vonage/client/subaccounts/MoneyTransfer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public String getReference() {
8989
* @param json The JSON string to parse.
9090
* @return An instance of this class with the fields populated, if present.
9191
*/
92-
protected static MoneyTransfer fromJson(String json) {
92+
public static MoneyTransfer fromJson(String json) {
9393
MoneyTransfer transfer = new MoneyTransfer();
9494
transfer.updateFromJson(json);
9595
return transfer;

src/main/java/com/vonage/client/verify/VerifyRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import java.util.Map;
2121

2222
/**
23-
* Describes a Verify request when passed to {@link VerifyEndpoint}.
23+
* Describes a Verify request.
2424
*/
2525
public class VerifyRequest extends BaseRequest {
2626
private final LineType type;

0 commit comments

Comments
 (0)