Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elevation] add 0dp elevation level #20

Open
jshenkman opened this issue Nov 24, 2021 · 3 comments
Open

[Elevation] add 0dp elevation level #20

jshenkman opened this issue Nov 24, 2021 · 3 comments
Assignees
@rachelbt
Labels
good first issue Good for newcomers

Comments

@jshenkman
Copy link

jshenkman commented Nov 24, 2021 •
edited by rachelbt
Loading

We need to add 0dp for elevation in which tere will be only border generated via filter similar to this:

--vvd-shadow-surface-0dp: filter: drop-shadow(var(--vvd-color-neutral-30) 1px 0px 0px) drop-shadow(var(--vvd-color-neutral-30) -1px 0px 0px) drop-shadow(var(--vvd-color
design:
https://www.figma.com/file/t1AdIumwvp9NzLyLAgvBO4/design.tokens?node-id=1%3A595
@jshenkman jshenkman changed the title [Elevation] add elevation level h Nov 24, 2021
@jshenkman jshenkman changed the title h [Elevation] add 0dp elevation level Nov 24, 2021
@yinonov yinonov transferred this issue from Vonage/vivid Nov 24, 2021
@yinonov yinonov added the good first issue Good for newcomers label Nov 25, 2021
@jshenkman
Copy link
Author

updated elevation dp 0 light & dark to be the same type as the rest

@yinonov yinonov linked a pull request Dec 26, 2021 that will close this issue
feat: elevation parser and tokens #18
Merged
@yinonov yinonov removed a link to a pull request Dec 26, 2021
feat: elevation parser and tokens #18
Merged
@yinonov
Copy link
Contributor

yinonov commented Dec 26, 2021

Vonage/vivid#1162

@rinaok rinaok assigned rachelbt and unassigned rinaok Dec 27, 2021
@rachelbt
Copy link

rachelbt commented Dec 28, 2021 •
edited
Loading

The tokens were as added by @YonatanKra :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rachelbt rachelbt

Labels
good first issue Good for newcomers
Projects
Vivid Roadmap
Status: Done ✅
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rachelbt @rinaok @yinonov @jshenkman