Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More relevant types for attributes #133

Open
jonlym opened this issue Dec 10, 2019 · 0 comments
Open

More relevant types for attributes #133

jonlym opened this issue Dec 10, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@jonlym
Copy link
Member

jonlym commented Dec 10, 2019

Upon reading the collections page, I realized some attributes could be updated:

Variable Old Type New Type Notes
pmutt.empirical.EmpiricalBase.elements dict Counter
pmutt.reaction.bep.BEP.elements dict Counter
pmutt.statmech.StatMech.elements dict Counter
pmutt.cantera._get_range_CTI.unique_headers dict default dict (list as the default_factory)
pmutt.io.chemkin.write_surf.cat_adsorbates dict default dict (list as the default_factory) May be easier to leave as dict since unique_cat_sites are identified using try/except block.
pmutt.io.omkm.write_yaml.phase_dict dict default dict (list as the default_factory)
pmutt.empirical.references.References.offset dict pandas.DataFrame
Output when using verbose=True for pmutt.statmech.StatMech.get_X tuple pandas.DataFrame
@jonlym jonlym added the enhancement New feature or request label Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant