Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TSNE perpelexity parameter for sklearn 1.2.1 #248

Open
himaghna opened this issue Feb 7, 2023 · 2 comments
Open

Fix TSNE perpelexity parameter for sklearn 1.2.1 #248

himaghna opened this issue Feb 7, 2023 · 2 comments
Assignees
@himaghna
Milestone
AIMSim v2.x

Comments

@himaghna
Copy link
Collaborator

himaghna commented Feb 7, 2023

No description provided.

@himaghna himaghna self-assigned this Feb 7, 2023
@JacksonBurns JacksonBurns added this to the AIMSim v2.x milestone Feb 7, 2023
@JacksonBurns
Copy link
Member

@himaghna I found out that the issue is (currently) only in the tests themselves, and was able to patch it over like this. If you could check in the clustering if it is possible that the default perplexity (30.0, as of sklearn 1) would ever be less than the number of samples and then write some defensive test for it, we should be covered.

@JacksonBurns
Copy link
Member

slight correction, it is now len(self.test_smiles) instead of n_features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@himaghna himaghna

Labels
None yet
Projects
None yet
Milestone
AIMSim v2.x
Development

No branches or pull requests
2 participants
@JacksonBurns @himaghna