Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping notifications #3

Open
Fabioah opened this issue Mar 2, 2021 · 5 comments · May be fixed by #6
Open

Overlapping notifications #3

Fabioah opened this issue Mar 2, 2021 · 5 comments · May be fixed by #6

Comments

@Fabioah
Copy link

Fabioah commented Mar 2, 2021

Hi, is there any way to make newer notifications to cover older ones like this patch for herbe do ?
dudik/herbe#14

@Vixeliz
Copy link
Owner

Vixeliz commented Mar 2, 2021

I'm sure it's something I can look into when I have a little more free time I don't think it would be that difficult to do. If so it will be a patch.

@Fabioah
Copy link
Author

Fabioah commented Mar 3, 2021

thank you

@Vixeliz Vixeliz linked a pull request Apr 24, 2021 that will close this issue
@Vixeliz
Copy link
Owner

Vixeliz commented Apr 24, 2021

Sorry for the long response time havent worked on wayherb much but you can try the above pr to see if that works(not at a pc to test rn so cant confirm if it works)

@Fabioah
Copy link
Author

Fabioah commented May 2, 2021

Thank you. It works but the first notification still stays for the time set in config file. In herbe with overlapping patch the first notification disappear immidiately after the second one gets called while the last one persist for some seconds.

@Vixeliz
Copy link
Owner

Vixeliz commented May 2, 2021

Im trying to understand do you want the timeout removed completely(so notifications always have to be closed manually). Or do you want the first notification to stay for the duration unless a new notification comes up then the first one disappears and the new one last the duration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants