Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Separate signals for transaction confirm and cancel #294

Open
ZenRepublic opened this issue Oct 13, 2024 · 0 comments
Open

Issue: Separate signals for transaction confirm and cancel #294

ZenRepublic opened this issue Oct 13, 2024 · 0 comments
Assignees

Comments

@ZenRepublic
Copy link

Description

Having separate signals for transaction confirmation and cancelling messes up the flow of sending a transaction.

Suggested Improvements

Merge these signals:
fully_signed()
signing_failed(signer_id)
signer_status_changed()

into one signal:
signing_finished(signer_id, result)

Another improvement could be to change the signal "send_ready" into a function:
is_send_ready()

it would check if all needed signers have signed and then user can act accordingly with their code after signing_finished()

Extra Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants