We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Having separate signals for transaction confirmation and cancelling messes up the flow of sending a transaction.
Merge these signals: fully_signed() signing_failed(signer_id) signer_status_changed()
into one signal: signing_finished(signer_id, result)
Another improvement could be to change the signal "send_ready" into a function: is_send_ready()
it would check if all needed signers have signed and then user can act accordingly with their code after signing_finished()
No response
The text was updated successfully, but these errors were encountered:
Virus-Axel
No branches or pull requests
Description
Having separate signals for transaction confirmation and cancelling messes up the flow of sending a transaction.
Suggested Improvements
Merge these signals:
fully_signed()
signing_failed(signer_id)
signer_status_changed()
into one signal:
signing_finished(signer_id, result)
Another improvement could be to change the signal "send_ready" into a function:
is_send_ready()
it would check if all needed signers have signed and then user can act accordingly with their code after signing_finished()
Extra Information
No response
The text was updated successfully, but these errors were encountered: