Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow self-signed certificate in electron app #2

Open
3 tasks
VigneshVSV opened this issue Jul 28, 2024 · 4 comments
Open
3 tasks

Allow self-signed certificate in electron app #2

VigneshVSV opened this issue Jul 28, 2024 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@VigneshVSV
Copy link
Owner

The electron build is stored in a different repository here

It does not allow self signed certificates (and also probably unencrypted HTTP). Possible steps

  • add logic that allows this in a safe way. User should try to open in new tab and allow certificate, just like a normal browser.
  • open in new tab not working, so fix that as well
  • Error message when certificate is not working is shown as "Network Error", improve that to suggest at least that the cause of the error might be the certificate.
@VigneshVSV VigneshVSV added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jul 28, 2024
@samubura
Copy link

I was trying to use the app with a self-hosted node-wot TD in localhost over HTTP
the error I get is related to mixed content
Blocked loading mixed active content “http://192.168.1.111:8080/thing”

Maybe allowing the app to be run in HTTP instead of HTTPS with a flag might already fix this?
I was running using npm run dev

@VigneshVSV
Copy link
Owner Author

Yes I think the issue is I forgot to add a HttpClientFactory apart from HttpsClientFactory within the node-wot client factories.

I am already testing, I will keep you updated in 10 minutes.

@VigneshVSV
Copy link
Owner Author

VigneshVSV commented Dec 17, 2024

I was wrong, you are right.

I just need to add a flag that can run the app with HTTP instead of HTTPS. For time being, you could comment out mkcert plugin in vite.config.ts line 10.

@VigneshVSV
Copy link
Owner Author

VigneshVSV commented Dec 17, 2024

There is a small config file called app.config.ts that can toggle SSL, you could try it out.

Pls ignore my previous comment that was in place of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants