Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete CriticalEvent Logic #20

Open
5 tasks
VigneshVSV opened this issue Jul 27, 2024 · 0 comments
Open
5 tasks

Complete CriticalEvent Logic #20

VigneshVSV opened this issue Jul 27, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@VigneshVSV
Copy link
Owner

VigneshVSV commented Jul 27, 2024

The idea of the CriticalEvent object was that one can receive acknowledgement for the server sent event. There is a similar idea in the thing description to support dataResponse for events.

Possible steps involved

  • solidify the CriticalEvent concept based on the suggestion given by the Thing Description spec. This may even involve renaming CriticalEvent to something else to indicate any response apart from an acknowledgement is also supported.
  • Support dataResponse in the init of CriticalEvent
  • Create a message in ZMQ & modify EventLoop.execute_once which will call the CriticalEvent's data response accepting method
  • Define how errors will be raised to the user
  • Idea should work for both HTTP & ZMQ transport
@VigneshVSV VigneshVSV added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant