Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ZMQ protocol specifying in HTTP server segregated by protocol vs. instance name mapping instead of a list of instance names #18

Open
3 tasks
VigneshVSV opened this issue Jul 27, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@VigneshVSV
Copy link
Owner

VigneshVSV commented Jul 27, 2024

Mostly, the HTTP server will be used in INPROC transport with Thing's ZMQ server - this means one hardware per process. Here ZMQ will work as a thread coordinator & scheduler, like a threading.Lock() object.

Nevertheless, for certain cases, people may want to use IPC with HTTP server or TCP communication with HTTP server for a hardware running in some other computer. Although support already exists for this from ZMQ side, it has not been added to HTTPServer's init

Possible steps -

  • Define how the first argument things has to be specified by the user, right now its a list with instance names and assumes IPC (which is again contradictory with the first statement of this issue) - it may be a dict of lists or whatever
  • edit HTTPServer.update_router_with_thing or zmq_client_pool to account the correct ZMQ protocol for each thing
  • edit Thing's own run_with_http_server method to account for INPROC correctly after making the changes
@VigneshVSV VigneshVSV added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 27, 2024
@VigneshVSV VigneshVSV changed the title Allow ZMQ protocol binding in HTTP server segragated by instance name instead of a list of instance names Allow ZMQ protocol specifying in HTTP server segregated by protocol vs. instance name mapping instead of a list of instance names Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant