Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound pitch is not translated between versions #802

Open
5 tasks done
Pablete1234 opened this issue Jun 23, 2024 · 4 comments
Open
5 tasks done

Sound pitch is not translated between versions #802

Pablete1234 opened this issue Jun 23, 2024 · 4 comments

Comments

@Pablete1234
Copy link

/viaversion dump Output

https://dump.viaversion.com/cf4487d47d27d9e029cb71ee8daa2431315a2fce876ea3ad855cda7a26f8f251

Console Error

No response

Bug Description

It appears that viaversion does not bother mapping the pitch of sounds, which leads to some things sounding very off.

The one thing that stands out is pressure plates, this is the serverside behavior across versions:
in 1.21, sends a "block.wooden_pressure_plate.click_on" with pitch 1.0F
in 1.18.2, sends a "block.wooden_pressure_plate.click_on" with pitch 0.8F (different for on/off and stone/wood)
in 1.8.8, sends a "random.click" with pitch 0.6F (diff for turning on/off)

However, viaversion will just translate the keys and call it a day, and when a 1.18.2 client hears the sound with a pitch of 1, it sounds way higher pitch than normal (0.8).

I am assuming that the sound in the vanilla pack itself has changed over time, so before the pitch was changed via the packet, while in the newest versions the sound file itself is already pitched to sound ok with a pitch of 1.0.
Pressure plates are the one we noticed, but this seems likely to have happened to more sounds.

Steps to Reproduce

Setup a server running in 1.20.6/1.21 paper

Log in with a 1.20.6/1.21 client
Step on a wooden and/or stone pressure plate
The sound is normal, it sounds correct

Log in with a 1.18.2 client
Step on a wooden and/or stone pressure plate
The sound is the correct one ("pressure plate clicks", as shown if accessibility->show subtitles is enabled) but the pitch is not the right one

Log in with a 1.8 client
Step on a wooden and/or stone pressure plate, the sound is very off, sounds like a dispenser not a pressureplate

Expected Behavior

The not just the key but the pitch should also be mapped across versions

Additional Server Info

No response

Checklist

@Barvalg
Copy link
Member

Barvalg commented Jun 23, 2024

Platform: 1.21--15--2df432f%20%28MC%3A%201.21%29
ViaVersion (5.0.1): Even with master
ViaBackwards(5.0.1): Even with master
ViaRewind(4.0.0): 5 commits behind master

Please update all Via* plugins from https://ci.viaversion.com/.In case the issue still persists send the new dump and the issue will be reopened

@Barvalg Barvalg closed this as not planned Won't fix, can't repro, duplicate, stale Jun 23, 2024
@Barvalg
Copy link
Member

Barvalg commented Jun 23, 2024

Platform: 1.21--15--2df432f%20%28MC%3A%201.21%29
ViaVersion (5.0.1): Even with master
ViaBackwards(5.0.1): Even with master
ViaRewind(4.0.1-SNAPSHOT): Even with master

@Barvalg Barvalg reopened this Jun 23, 2024
@Barvalg Barvalg removed the invalid label Jun 23, 2024
@Pablete1234 Pablete1234 changed the title Pitch is not translated between versions Sound pitch is not translated between versions Jun 23, 2024
@FlorianMichael FlorianMichael transferred this issue from ViaVersion/ViaRewind Jun 27, 2024
@kennytv
Copy link
Member

kennytv commented Jul 8, 2024

Related to #526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants