Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylint problems #16

Open
7 tasks
JiriPavela opened this issue Feb 6, 2023 · 0 comments
Open
7 tasks

Fix pylint problems #16

JiriPavela opened this issue Feb 6, 2023 · 0 comments
Assignees

Comments

@JiriPavela
Copy link
Collaborator

JiriPavela commented Feb 6, 2023

The codebase contains a lot of pylint errors and warnings. Some of them are rather minor, however, there are some more serious issues that should definitely be addressed. I'm adding a task list of pylint errors (sorted subjectively from the most to least severe) that should be resolved in a corresponding PR:

  • Catching too broad exceptions. This can result in improper handling of unrelated exceptions.
  • Explicitly specify the encoding when manipulating files PEP 597.
  • Improper None comparison operators (== or != instead of is or is not).
  • Unused variables (e.g., unused return values) should be denoted as _ to not pollute the namespace.
  • Rewrite if-elif-else constructions with return statements inside.
  • Unify string formatting, preferably using the f-strings.
  • Improper usage of multiline strings as comments, or their improper location resulting in them not being recognized as docstrings.

For now, I'd suggest ignoring warnings related to missing docstrings, as that is much more time-consuming task warranting a standalone issue.

@JiriPavela JiriPavela self-assigned this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant