Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate if all tracks have been played at the end #24

Open
dmcrodrigues opened this issue Feb 18, 2016 · 2 comments
Open

Validate if all tracks have been played at the end #24

dmcrodrigues opened this issue Feb 18, 2016 · 2 comments
Labels
Milestone

Comments

@dmcrodrigues
Copy link
Member

This provides an extra guarantee in conjunction with #22.

@RuiAAPeres
Copy link
Member

It might make sense to instead return a tuple (numberOfTracksPlayed, numberOfTracksAvailable). This for me is particular useful to assert expectations. I had cases where with RAC, I was expecting an HTTP Request to be made once, and it was actually being called twice.

@dmcrodrigues
Copy link
Member Author

You can restrict the number of times a certain track, and consequently a request, should and can be played using #22, so right now you have mechanisms to catch that kind of situations where a request was performed twice instead of one.

But I see your point and one of our main goals is flexibility and with that in mind I would like to propose provide hooks to promote extensibility and which could be the base to support that kind of validations. Do you agree with that approach?

@dmcrodrigues dmcrodrigues modified the milestone: 1.0 Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants