Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest using CMAKE_BINARY_DIR to copy vc142.pdb for a CMake out-of-source build #27

Open
areong opened this issue Aug 3, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@areong
Copy link

areong commented Aug 3, 2020

Problem

I built from source with Visual Studio Code CMake Tools, and the build process exited with an error copying file unity-xr-plugin/XRSDKOPENVR.dir/Release/vc142.pdb.

Configurations: VS Community 2019 Release x86_amd64

Proposed solution

At line 165 in CMakeLists.txt, replace CMAKE_SOURCE_DIR with CMAKE_BINARY_DIR such that the path to the PDB file becomes unity-xr-plugin/build/XRSDKOPENVR.dir/Release/vc142.pdb in an out-of-source build. CMake builds successfully with this modification. I did not test the built binaries however.

@1runeberg 1runeberg self-assigned this Aug 3, 2020
@1runeberg 1runeberg added the enhancement New feature or request label Aug 3, 2020
@rpavlik
Copy link

rpavlik commented Oct 5, 2020

fwiw, this is resolved by #55

@areong
Copy link
Author

areong commented Oct 7, 2020

fwiw, this is resolved by #55

@rpavlik Wow thank you. I have not tried your pr yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants