Skip to content

Missing whitespace between : and " on some attributes #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TristanRobitaille opened this issue Nov 1, 2024 · 4 comments
Closed

Missing whitespace between : and " on some attributes #256

TristanRobitaille opened this issue Nov 1, 2024 · 4 comments

Comments

@TristanRobitaille
Copy link

TristanRobitaille commented Nov 1, 2024

Describe the bug
Missing required whitespace between : and " in some groups. This is an example, notice the :" before min_pulse_width and minimum_period.

image

Version
v1.2.48

To Reproduce
Any valid configuration should lead to the same issue, but here's an example I used.

num_words = 32
tech_name = "scn4m_subm"
process_corners = ["TT"]
supply_voltages = [ 3.3 ]
temperatures = [25]
output_path = "temp"
output_name = "sram_32x8"
netlist_only = False

Expected behavior
Per Liberty spec, a whitespace is required.
https://media.c3d2.de/mgoblin_media/media_entries/659/Liberty_User_Guides_and_Reference_Manual_Suite_Version_2017.06.pdf
image

Additional context
This bug leads to parsing failure on a parser like liberty-parser.

@mguthaus
Copy link
Collaborator

mguthaus commented Nov 1, 2024

Can you submit a PR?

@TristanRobitaille
Copy link
Author

Yes, just made one: #257

@TristanRobitaille
Copy link
Author

@mguthaus Just following up on this small PR, thank you.

@mguthaus
Copy link
Collaborator

mguthaus commented Dec 3, 2024

It was merged into the dev branch 3 weeks ago. It hasn't been moved to stable because there are some other regression issues.

@mguthaus mguthaus closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants