Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDA viz - continuous variable overlays switch from gradient to discrete when heavily subsetted #1583

Open
danicahelb opened this issue Jan 27, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@danicahelb
Copy link

Data viz topic:

heavy subsetting switches the legend for a continuous variable from the gradient to the standard categorical colormap

See: GEMS1 scatterplot using BMI-for-age as overlay:

unsubsetted:
image

with heavy subsetting:
image

@asizemore
Copy link
Member

yikes this looks like a bug. transferring to web-eda

@moontrip
Copy link
Contributor

@danicahelb @asizemore I have checked this and looked into corresponding web-eda part. I tried to mimic the behavior and confirmed that it happened when the number of data points are small. What happens in this case is that the backend does not return gradient data (seriesGradientColorscale) to the frontend (perhaps due to the lack of data points to compute gradient level?). So, the frontend treats such a small number of data points as a normal plot.

Thus, I don't know what you want in this case without having the backend data. Perhaps current behavior is what it should be?

@danicahelb
Copy link
Author

i dont think we want to keep the current behavior, it is very confusing

@moontrip what is a "small" number of data points? is the issue the number of data points or the number of unique overlay values for that small set of data points?

@d-callan can we adjust something on the backend?

@d-callan
Copy link
Contributor

This should get fixed in plot.data in the short term, and this ticket transferred there. In the longer term we probably want the client to dictate which colormaps it'd like to use? That's probably worth a separate discussion and ticket.

@moontrip
Copy link
Contributor

Thanks @d-callan for taking care of it.
@danicahelb Honestly, I don't know exact condition that happens. From my various tests, it occurs when the number of data points is small, usually less than 8 points.

@danicahelb
Copy link
Author

@d-callan i've made this placeholder ticket for the convo about the client dictating which colormap to use VEuPathDB/EdaNewIssues#606

@aurreco-uga aurreco-uga changed the title continuous variable overlays switch from gradient to discrete when heavily subsetted EDA viz - continuous variable overlays switch from gradient to discrete when heavily subsetted May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants