Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tooltips for all visualizations with continuous overlays #455

Open
danicahelb opened this issue Jan 27, 2023 · 10 comments · May be fixed by VEuPathDB/web-eda#1691
Open

update tooltips for all visualizations with continuous overlays #455

danicahelb opened this issue Jan 27, 2023 · 10 comments · May be fixed by VEuPathDB/web-eda#1691
Assignees

Comments

@danicahelb
Copy link

the mouse-over information for continuous overlays should include the "z" axis value

@d-callan
Copy link
Contributor

d-callan commented Feb 7, 2023

i agree w this, though think if we can be consistent w tooltips regardless of colormap thats also good. but that probably just means updating this ticket to showing overlay values in tooltips regardless of whether the overlay is gradient?

@dmfalke dmfalke transferred this issue from VEuPathDB/EdaNewIssues Feb 16, 2023
@moontrip moontrip self-assigned this Mar 8, 2023
@moontrip
Copy link
Contributor

moontrip commented Mar 14, 2023

Hi @danicahelb @d-callan

I could make a mouse-over info to reflect on the value of continuous overlay. But it raises a couple of questions to finalize, so it would be great if you can answer me.
a) what kind of the info format you want? Current format without z-value is:
(x-value, y-value)

My pure guess is like:
x: x-value
y: y-value
value: z-value (the wording, 'value' is okay? Any suggestion is welcome!)
overlay name (like 'Case')

So, above will be similar to below image, but overlay name is included inside the info tooltip instead, as @d-callan said.
211737657-e7cd97f9-b9a3-44d5-8123-9b42cfb03318

b) there is a related ticket #453. I can certainly unify the format, perhaps except Lineplot and Boxplot where the latter is a bit tricky due to the number of contents but perhaps doable as a single info tooltip: but I feel that the current Boxplot format looks good though because the default plotly's tooltip automatically indicates the location of each property (e.g., location of max, mean etc.) - probably this cannot be achieved by a manual formatting. Anyway, it is not quite sure of the format of Histogram and Barplot you want, which currently shows the format like:
count-value
x-value
overlay name

Do you want it like (a mixture of the current Histogram and Lineplot format):
x: x-value
n: count-value
overlay name

@danicahelb
Copy link
Author

the tooltip for line plots was updated in b62 (VEuPathDB/EdaNewIssues#547), and now looks like this:

Categorical overlay
image

Continuous overlay
there seems to be a bug with continuous overlays. see: VEuPathDB/EdaNewIssues#604

@moontrip i wanted to compare how the tooltips look before answering your questions. but i think the verbiage should be Overlay variable name: Overlay variable value as a 4th line under what Jeremy implemented in b62. We could get rid of the overlay value that is currently outside of the colored box

also, this hasn't been assigned to a build yet, and it would be best to continue with remaining b62 tickets until we finalize b63 priorities. thanks!

@moontrip
Copy link
Contributor

@danicahelb Thank you for your information. I made a couple of screenshots for you. Hope this would be helpful! 😃 Please note that texts inside the tooltip can be easily changed and I feel that Overlay variable name: Overlay variable value is a bit long: but doable if you prefer. Also, as Danielle said, continuous overlay is currently only available at Scatterplot so lineplot is not the case to consider as of now VEuPathDB/EdaNewIssues#604 (comment))

Scatterplots

a) current formats at Live site
a-1) no overlay
scatter-current01
a-2) with overlay variable: overlay name is automatically made at the second box by plotly
scatter-current02

b) Dev: no overlay variable is selected
scatter-continuous-overlay-tooltip00

c) Dev: with overlay variable, but not continuous
scatter-continuous-overlay-tooltip01

d) Dev: with continuous overlay variable
scatter-continuous-overlay-tooltip02

@bobular
Copy link
Member

bobular commented Mar 17, 2023

Hi @moontrip - I like the look of this.

For categorical overlays, the old default behaviour with the overlay category value hanging outside the box was often invisible to me, even though as a developer I knew it should be there. So the new "thinking inside the box" is welcome.
image

As for "Overlay variable name: Overlay variable value" verbiage - I agree this might get VERY long for some variables. I doubt we'll have the opportunity to provide mouse-over ellipses. So I give a +1 to DK's "overlay: " verbiage.

@moontrip
Copy link
Contributor

@bobular Thank you for sharing your thoughts 👍

@danicahelb
Copy link
Author

Overlay: is fine

but it should say Overlay: and not Value: for continuous overlay variables

@moontrip
Copy link
Contributor

Overlay: is fine

but it should say Overlay: and not Value: for continuous overlay variables

@danicahelb Thank you for your suggestion I will reflect it 👍

@danicahelb
Copy link
Author

@moontrip I'm going to move this ticket to backlog as it is not something we need to work on right now

@moontrip
Copy link
Contributor

@danicahelb Thank you for your information 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants