Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Technical debt: relocate ColorPaletteAddon usage #192

Open
bobular opened this issue Aug 19, 2021 · 0 comments
Open

Technical debt: relocate ColorPaletteAddon usage #192

bobular opened this issue Aug 19, 2021 · 0 comments
Labels
low cost plot Something related to a plot component tidy-up tidy up or refactor but no change in functionality

Comments

@bobular
Copy link
Member

bobular commented Aug 19, 2021 •
edited
Loading

See discussion at the end of #187

Move ColorPaletteAddon usage out of PlotlyPlot's PlotProps and into all the other plots except Heatmap

But keep it like this (as Connor had it before...!)

export default function PlotlyPlot<T>(
  props: Omit<PlotProps<T>, 'data'> & PlotParams & ColorPaletteAddon
) {
@bobular bobular added tidy-up tidy up or refactor but no change in functionality plot Something related to a plot component low cost labels Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low cost plot Something related to a plot component tidy-up tidy up or refactor but no change in functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bobular