Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on delete, write flag to minio before updating PG #290

Closed
Foxcapades opened this issue May 6, 2024 · 0 comments · Fixed by #312
Closed

on delete, write flag to minio before updating PG #290

Foxcapades opened this issue May 6, 2024 · 0 comments · Fixed by #312

Comments

@Foxcapades
Copy link
Member

Foxcapades commented May 6, 2024

Currently the PG row is updated to mark a dataset as deleted before the flag is written to minio. If the write to minio fails, the dataset will be left in a weird state where the pruner will refuse to remove the dataset.

@Foxcapades Foxcapades added the todo label May 6, 2024
@Foxcapades Foxcapades changed the title on delete write flag to minio before updating PG on delete, write flag to minio before updating PG May 15, 2024
@Foxcapades Foxcapades added this to the Build 69 milestone May 16, 2024
@Foxcapades Foxcapades linked a pull request May 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant