Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite/simplify dataset reinstaller. #221

Open
Foxcapades opened this issue Feb 6, 2024 · 0 comments
Open

Rewrite/simplify dataset reinstaller. #221

Foxcapades opened this issue Feb 6, 2024 · 0 comments

Comments

@Foxcapades
Copy link
Member

Right now the data-install lane already attempts to install datasets that are in the ready-for-reinstall status. The dataset reinstaller also attempts to install datasets that are in the ready-for-reinstall status.

I suggest that we clarify and simplify the dataset reinstallation process by doing the following:

  1. Add a new InstallStatus enum member ready-for-cleanup which will indicate to the dataset-reinstaller that the dataset is able to be cleaned up and reinstalled
  2. Alter the dataset-reinstaller to:
    a. Uninstall datasets in the ready-for-cleanup status
    b. Mark uninstalled datasets as ready-for-reinstall
    c. Fire install events for the uninstalled datasets

This will remove the duplicated dataset installation logic and clarify the usages of the ready-for-reinstall status which is currently overloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant