Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site search feedback on descriptors / terminologies used in results #287

Closed
danicahelb opened this issue May 23, 2022 · 3 comments · Fixed by VEuPathDB/EbrcWebsiteCommon#144
Assignees

Comments

@danicahelb
Copy link

We need better descriptors for “categories path”, “name”, and “study info”.
Also “entity” is terminology that should only be used internally, so we should rename this also

@danicahelb
Copy link
Author

danicahelb commented Jun 9, 2022

When better terminology for "entity" is agreed upon, also implement the change in this ticket: VEuPathDB/EdaDataService#180

Perhaps we could use "observational unit" as external facing language instead on "entity"? see: https://cran.r-project.org/web/packages/tidyr/vignettes/tidy-data.html

so "Parent observational unit" instead of "Parent entity"?

@danicahelb
Copy link
Author

danicahelb commented Jun 13, 2022

Discussed in 6/13 EDA UX meeting

For “Studies” filter results: No changes are needed at this time
- Note that "Fields matched: Category” has been changed for the “Studies filter” already but has not been changed for the “Variables” filter (see below)

For “Variables” filter results:

  • Server
    • “Studies matched”, change to: “Study specific variable information” (This should match the what was previously labeled “Study info”)
    • Fields matched: “Categories path”, change to: “Category” (Note that "Fields matched: Category” has been changed for the “Studies filter” already but has not been changed for the “Variables” filter)
    • Fields matched: “Name”, change to: “Variable name”
    • Fields matched: “Study info”, change to: “Study specific variable information” (This should match the what was previously labeled “Studies matched”)
  • Client

For “Variable values” filter results:

  • Server
    • “Studies matched”, change to: “Variables having this value”
    • Fields matched: “VariableValue”, change to: “Variable value”
  • Client

@danicahelb
Copy link
Author

looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants