Extra Slash in URL

[sankarcn]

Kindly refer to the below code snippet.
Can you please help me where I am going wrong.
An extra slash is getting added after json.
Seems to be generating a URL like below.
/maps/api/distancematrix/json/?origins=Tabazco+Stora+Gatan+36B+V%C4STER%C5S+722+12&destinations=Puls+Slottsgatan+118+NORRK%D6PING+602+20&units=metric

There is an extra slash added after json. Can you please help figure out where I am doing a mistake.
'Call the distance API to get the distance
GoogleClient.BaseUrl = "https://maps.googleapis.com/maps/api/distancematrix/"
GoogleRequest.Resource = "json"
GoogleRequest.Method = WebMethod.HttpGet
GoogleRequest.RequestFormat = WebFormat.FormUrlEncoded
GoogleRequest.ResponseFormat = WebFormat.Json
GoogleRequest.AddQuerystringParam "origins", OriginAddress
GoogleRequest.AddQuerystringParam "destinations", DestinationAddress
GoogleRequest.AddQuerystringParam "units", "metric"
GoogleRequest.AddQuerystringParam "key", AccessKey

[zgrose]

I gave this a whirl:

Public Sub TestExtraSlash()

Dim GoogleClient As New WebClient
Dim GoogleRequest As New WebRequest
GoogleClient.BaseUrl = "https://maps.googleapis.com/maps/api/distancematrix/"
GoogleRequest.Resource = "json"
GoogleRequest.Method = WebMethod.HttpGet
GoogleRequest.RequestFormat = WebFormat.FormUrlEncoded
GoogleRequest.ResponseFormat = WebFormat.Json
GoogleRequest.AddQuerystringParam "origins", OriginAddress
GoogleRequest.AddQuerystringParam "destinations", DestinationAddress
GoogleRequest.AddQuerystringParam "units", "metric"
GoogleRequest.AddQuerystringParam "key", AccessKey

Debug.Print GoogleClient.GetFullUrl(GoogleRequest)

End Sub

and I get
https://maps.googleapis.com/maps/api/distancematrix/json?origins=&destinations=&units=metric&key=

I even tried Debug.Print GoogleClient.PrepareCurlRequest(GoogleRequest) in case you were on a Mac and I see:

curl -i --connect-timeout 5 --max-time 15 --location -H 'User-Agent: VBA-Web v4.1.1 (https://github.com/VBA-tools/VBA-Web)' -H 'Content-Type: application/x-www-form-urlencoded;charset=UTF-8' -H 'Accept: application/json' -H 'Content-Length: 0' -X GET -d '' 'https://maps.googleapis.com/maps/api/distancematrix/json?origins=&destinations=&units=metric&key='

[sankarcn]

The problem seems to be with the URL coding for Swedish Language. It is possible that I am doing something wrong. Thanks for your patience.

Sub GetTimeAndDistance(ByVal FromPlaceNumber As Long, ByVal ToPlaceNumber As Long)
Dim GoogleClient As New WebClient
Dim GoogleRequest As New WebRequest
Dim GoogleResponse As WebResponse
Dim AccessKey As String
Dim OriginAddress As String
Dim OriginAddressRowNumber As Long
Dim RangeFound As Range
Dim RowInResponse As Dictionary

Dim DestinationAddress As String
Dim DestinationAddressRowNumber As Long

Dim DistanceValue As Long
Dim TimeValue As Long



AccessKey = ThisWorkbook.Worksheets("Setup").Range("C4").Value

'**** Code to populate Originaddress and Destination Address

'Call the distance API to get the distance
GoogleClient.BaseUrl = "https://maps.googleapis.com/maps/api/distancematrix/"
GoogleRequest.Resource = "json"
GoogleRequest.Method = WebMethod.HttpGet
GoogleRequest.RequestFormat = WebFormat.FormUrlEncoded
GoogleRequest.ResponseFormat = WebFormat.Json
GoogleRequest.AddQuerystringParam "origins", OriginAddress
GoogleRequest.AddQuerystringParam "destinations", DestinationAddress
GoogleRequest.AddQuerystringParam "units", "metric"
GoogleRequest.AddQuerystringParam "key", AccessKey

Set GoogleClient.Authenticator = Nothing

Debug.Print (OriginAddress)
Debug.Print (DestinationAddress)
Debug.Print ("")
Debug.Print GoogleClient.GetFullUrl(GoogleRequest)
Debug.Print ("")
Debug.Print GoogleClient.PrepareCurlRequest(GoogleRequest)

The immediate Window shows like this:

Tabazco Stora Gatan 36B VÄSTERÅS 722 12
Puls Slottsgatan 118 NORRKÖPING 602 20

https://maps.googleapis.com/maps/api/distancematrix/json?origins=Tabazco+Stora+Gatan+36B+V%C4STER%C5S+722+12&destinations=Puls+Slottsgatan+118+NORRK%D6PING+602+20&units=metric&key=AIzaSyA7B3crL6DM1LjGHNe72MwssdLL1xMMZz8

curl -i --connect-timeout 5 --max-time 15 --location -H 'User-Agent: VBA-Web v4.1.4 (https://github.com/VBA-tools/VBA-Web)' -H 'Content-Type: application/x-www-form-urlencoded;charset=UTF-8' -H 'Accept: application/json' -H 'Content-Length: 0' -X GET -d '' 'https://maps.googleapis.com/maps/api/distancematrix/json?origins=Tabazco+Stora+Gatan+36B+V%C4STER%C5S+722+12&destinations=Puls+Slottsgatan+118+NORRK%D6PING+602+20&units=metric&key=AIzaSyA7B3crL6DM1LjGHNe72MwssdLL1xMMZz8'

If I paste the URL on a web browser, I get the same error.
When I use let us say "Bangalore, India" and "Chennai, India" as source and destination address, I get the proper response.

[timhall]

Thanks for the additional details @sankarcn I'll look into it.

[sankarcn]

Summary... I used a urlconverter (Courtesy Tom) and it was working.

[sankarcn]

Tabazco Stora Gatan 36B VÄSTERÅS 722 12
In Web-Vba is converting to
Tabazco+Stora+Gatan+36B+V%C4STER%C5S+722+12
While another URL converter is converting to below and it works.
Tabazco+Stora+Gatan+36B+V%C3%84STER%C3%85S+722+12

The URL converted that I used is the first code shown in the answer for
https://stackoverflow.com/questions/218181/how-can-i-url-encode-a-string-in-excel-vba