Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKEND] Fix edit event endpoint to properly add timestamps #802

Closed
7 tasks
choden-dev opened this issue Oct 8, 2024 · 0 comments · Fixed by #808
Closed
7 tasks

[BACKEND] Fix edit event endpoint to properly add timestamps #802

choden-dev opened this issue Oct 8, 2024 · 0 comments · Fixed by #808
Assignees
Labels
backend relating to code in the /server directory bug Something isn't working

Comments

@choden-dev
Copy link
Member

Is your feature request related to a problem? Please describe.

Right now in server\src\service-layer\controllers\AdminController.ts the editEvent method does not properly parse the timestamps, see the following example:

        sign_up_start_date: new Timestamp(
          body.data.sign_up_start_date.seconds,
          body.data.sign_up_start_date.nanoseconds
        ),

is how it should be done

BEFORE MERGING

  • Integration test written for services
  • Schemas annotated if adding new models
  • Code generation run (hint: yarn workspace server tsoa spec-and-routes)
  • Appropriate mocks created where possible
  • PR Reviewed (For non-trivial changes)
  • Changes tested after rebasing on master or merging in master (hint: git fetch origin master:master, then git rebase master or git merge master)
  • All required PR checks passing
@choden-dev choden-dev added backend relating to code in the /server directory bug Something isn't working labels Oct 8, 2024
@jeffplays2005 jeffplays2005 self-assigned this Oct 16, 2024
@jeffplays2005 jeffplays2005 linked a pull request Oct 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend relating to code in the /server directory bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants