Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at rewriting photon emitters into a single cpp file #20

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

andrewgait
Copy link
Collaborator

Resolves #13

Making it possible to load photons either from a dict (via a VolumeGrid code object, or from a binary file) or XML (from a binary file).

Added a simple test script to the SingleEmitter directory which can be used for any of the three cases. (Note that it's not possible to load a code object from an XML file).

Leaving in draft form for now while I consider whether there are any improvements or simplifications to the code as it stands.

…g either from a dict or XML

- Added a simple test script  to the SingleEmitter directory

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably good to turn this into a test in the test directory, so that when all the tests are run, we check that the new loading code gives the same result as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to load data from a file rather than a code object in the (new) photon emitter
2 participants