Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean Config Parameter Output #398

Open
dANW34V3R opened this issue Feb 21, 2024 · 0 comments
Open

Boolean Config Parameter Output #398

dANW34V3R opened this issue Feb 21, 2024 · 0 comments

Comments

@dANW34V3R
Copy link
Contributor

Currently, if you incorrectly type "True" or "False" for any of the config options the resulting error is simply:

/.../SimEng/src/include/simeng/config/yaml/ryml.hh:20693:could not deserialize value

Process finished with exit code 134 (interrupted by signal 6:SIGABRT)

This doesn't give enough information to decern what or where the issue is. Ideally we would have a print out similar to:

[SimEng:ModelConfig] Invalid ISA value of "rv64asdf" passed in config file due to "rv64asdf not in set {AArch64, rv64}" error. Cannot continue with config validation. Exiting.

There may not be a simple solution to this. Options include first comparing as a string before converting or erroring. It may be possible to catch the error from RYAML and then giving a more more informative print out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ToDo
Development

No branches or pull requests

1 participant